- Issue created by @longwave
- Status changed to Needs review
2 months ago 11:49am 8 July 2024 - 🇬🇧United Kingdom longwave UK
+----------------------------------+---------+---------+ | Production Changes | From | To | +----------------------------------+---------+---------+ | composer/installers | v2.2.0 | v2.3.0 | | symfony/console | v7.1.1 | v7.1.2 | | symfony/dependency-injection | v7.1.0 | v7.1.2 | | symfony/error-handler | v7.1.0 | v7.1.2 | | symfony/event-dispatcher | v7.1.0 | v7.1.1 | | symfony/filesystem | v7.1.1 | v7.1.2 | | symfony/http-foundation | v7.1.0 | v7.1.1 | | symfony/http-kernel | v7.1.0 | v7.1.2 | | symfony/mailer | v7.1.0 | v7.1.2 | | symfony/mime | v7.1.0 | v7.1.2 | | symfony/polyfill-ctype | v1.29.0 | v1.30.0 | | symfony/polyfill-iconv | v1.29.0 | v1.30.0 | | symfony/polyfill-intl-grapheme | v1.29.0 | v1.30.0 | | symfony/polyfill-intl-idn | v1.29.0 | v1.30.0 | | symfony/polyfill-intl-normalizer | v1.29.0 | v1.30.0 | | symfony/polyfill-mbstring | v1.29.0 | v1.30.0 | | symfony/psr-http-message-bridge | v7.1.0 | v7.1.1 | | symfony/routing | v7.1.0 | v7.1.1 | | symfony/serializer | v7.1.0 | v7.1.2 | | symfony/string | v7.1.1 | v7.1.2 | | symfony/validator | v7.1.0 | v7.1.2 | | symfony/var-dumper | v7.1.0 | v7.1.2 | | symfony/var-exporter | v7.1.0 | v7.1.2 | | symfony/yaml | v7.1.0 | v7.1.1 | | twig/twig | v3.10.2 | v3.10.3 | +----------------------------------+---------+---------+ +------------------------------------+----------+----------+ | Dev Changes | From | To | +------------------------------------+----------+----------+ | justinrainbow/json-schema | v5.2.13 | 5.3.0 | | myclabs/deep-copy | 1.11.1 | 1.12.0 | | nikic/php-parser | v5.0.2 | v5.1.0 | | phpdocumentor/reflection-docblock | 5.4.0 | 5.4.1 | | phpstan/extension-installer | 1.3.1 | 1.4.1 | | phpstan/phpdoc-parser | 1.29.0 | 1.29.1 | | phpstan/phpstan | 1.11.1 | 1.11.7 | | phpunit/php-code-coverage | 10.1.14 | 10.1.15 | | phpunit/phpunit | 10.5.20 | 10.5.26 | | sirbrillig/phpcs-variable-analysis | v2.11.18 | v2.11.19 | | squizlabs/php_codesniffer | 3.9.2 | 3.10.1 | | symfony/browser-kit | v7.1.0 | v7.1.1 | | symfony/css-selector | v7.1.0 | v7.1.1 | | symfony/dom-crawler | v7.1.0 | v7.1.1 | | symfony/lock | v7.1.0 | v7.1.1 | | webflo/drupal-finder | 1.3.0 | 1.3.1 | +------------------------------------+----------+----------+
- 🇬🇧United Kingdom longwave UK
The test compares the pinned dev dependencies with the composer.json for the tests, this is just to ensure that both sets of tests run on the same version I think?
After the last round of updates, composer.json is ^1.11.0 but core-dev-pinned is 1.11.1 and core/tests/PHPStan/composer.json is 1.11.1 to match.
- 🇳🇱Netherlands Spokje
As far as I can tell the latest commit on the MR changes the version of PHPStan
core/tests/PHPStan/composer.json
to1.11.7
?
https://git.drupalcode.org/project/drupal/-/merge_requests/8701/diffs?co... - 🇬🇧United Kingdom longwave UK
Sorry yeah I meant in 📌 Update Composer dependencies for 11.0.0-beta1 Fixed we updated both to 1.11.1, and in this MR we are updating both to 1.11.7.
- 🇳🇱Netherlands Spokje
Ah ok, so my question boils down to: If we raise the recommended version and the version we run tests on is 1.11.7, should we still advertise the 1.11.1 version as a minimum, or should we bump to 1.11.7 in the root
composer.json
?Highly unlikely this will break something in this instance, but might do in a future update and it "just" feels weird to allow a minimum version that we don't actively test on.
But n=1, yadada and if it's decide that's OK, I'm fine with it.
- 🇬🇧United Kingdom longwave UK
This is only for testing our own PHPStan extensions, given there were no other failures I don't think it's worth bumping the minimum in composer.json; if something else had broken then that would suggest we should bump it (similar to when PHPStan introduces fixes that affect our baseline).
- Status changed to RTBC
2 months ago 2:07pm 8 July 2024 - 🇫🇷France andypost
justinrainbow/json-schema | v5.2.13 | 5.3.0
one more compatible extension with PHP 8.4, next composer release will contain it - Status changed to Fixed
2 months ago 9:46am 9 July 2024 - 🇬🇧United Kingdom catch
Committed/pushed to 11.x and cherry-picked to 11.0.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.