Contrib.social

README contains incorrect usage of TranslatableMarkup

Open on Drupal.org →
Created on 4 July 2024, 4 months ago
Updated 5 July 2024, 4 months ago

Problem/Motivation

The README is a really great overview of the module! Unfortunately it shows TranslatableMarkup which is used with a variable. However, such usage is disallowed and the first argument to TranslatableMarkup or related functions should always be a static string. This ensures that Drupal's translation template extractor → can properly find the string and make it available for translation on https://translate.drupal.org/

Since this is documentation, this is not a big issue, but it might encourage newcomers to do the wrong thing and run into unexpected problems.

Steps to reproduce

Proposed resolution

Inline the $str variable so that the full string is statically provided as first argument to TranslatableMarkup.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

RTBC

Version

3.0

Component

Documentation

Created by

🇳🇱Netherlands kingdutch

Live updates comments and jobs are added and updated live.
  • Novice

    It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.

Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024