- Issue created by @quietone
- Status changed to Needs review
5 months ago 5:29am 4 July 2024 - π¬π§United Kingdom alexpott πͺπΊπ
I think given we have to sort the index on Postgres the assertions are largely pointless.
- First commit to issue fork.
- Status changed to RTBC
5 months ago 8:43am 4 July 2024 - π¬π§United Kingdom longwave UK
Why not just check that the index exists after the update? We should trust that the database driver has tests that ensure an index is actually structured correctly, we don't need to re-assert that here.
- π¬π§United Kingdom alexpott πͺπΊπ
Opened π Postrges implementation of introspectIndexSchema is incorrect Active to fix the postgres schema inspection issue - I think the postgres implementation is incorrect and sorting by column name makes the method less valuable.
- π¬π§United Kingdom alexpott πͺπΊπ
@longwave pointed out we should be able to trust our APIs and not assrt against the internals - so removed the assertions on index structure.
- π¬π§United Kingdom catch
Committed/pushed to 11.x and cherry-picked back through to 10.3.x, thanks!
- Status changed to Fixed
5 months ago 9:00am 4 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.