- Issue created by @alexpott
In 📌 StorageComparer should not wrap sourceStorage with a memory cache if it extends \Drupal\Core\Config\FileStorage Fixed we removed source storage caching if the source storage is a FileStorage but actually if we did 📌 Allow parsing and writing PHP constants and enums in YAML files Needs work we will undo it. Unfortunately the strategy of adding a cache here is tricky because we accept so many storage types. It needs to be up to the caller to decide this. The current implementation and the previous one are examples of premature optimisations - prior to 📌 StorageComparer should not wrap sourceStorage with a memory cache if it extends \Drupal\Core\Config\FileStorage Fixed in the most usual usage of storage comparer (i.e. reading config from disk during an import) we are creating a double cache.
Remove the cache wrapper. It is an internal implementation detail and add comments to the class about using a cache wrapper if you need to.
None
None
NOne
N/a
Active
11.0 🔥
Last updated