StorageComparer should not wrap sourceStorage with a memory cache if it extends \Drupal\Core\Config\FileStorage

Created on 19 January 2024, 6 months ago
Updated 7 February 2024, 5 months ago

Problem/Motivation

Whilst working on YAML file parsing caching I noticed that \Drupal\Core\Config\FileStorage use FileCache. This means that the MemoryStorage wrap in \Drupal\Core\Config\StorageComparer::__construct() is pointless.

Steps to reproduce

Import config.

Proposed resolution

Check if $source_storage is a FileStorage before wrapping.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ“Œ Task
Status

Fixed

Version

11.0 πŸ”₯

Component
ConfigurationΒ  β†’

Last updated 41 minutes ago

Created by

πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024