- Issue created by @dev2.addweb
- Issue was unassigned.
- Status changed to Needs review
7 months ago 6:31am 3 July 2024 - š®š³India dev2.addweb
Hi,
I have fixed phpcs issue and Created MR. Please review - Status changed to Needs work
7 months ago 7:15am 4 July 2024 - šµšPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!1 and it was applied smoothly. However, I still encountered some errors after I ran
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml.ā feedback_ai git:(1.0.x) curl https://git.drupalcode.org/project/feedback_ai/-/merge_requests/1.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 18356 0 18356 0 0 51371 0 --:--:-- --:--:-- --:--:-- 51273 Checking patch README.md... Checking patch feedback_ai.info.yml... Checking patch feedback_ai.libraries.yml... Checking patch feedback_ai.routing.yml... Checking patch feedback_ai.services.yml... Checking patch src/Form/FeedbackAIForm.php... Checking patch src/Plugin/Block/FeedbackAIBlock.php... Checking patch src/Plugin/Block/SentimentChartBlock.php... Checking patch src/Plugin/views/filter/FeedbackAiDateBase.php... Checking patch templates/feedback-ai-block.html.twig... Checking patch templates/feedback-ai-price-modal.html.twig... Checking patch templates/sentiment-chart.html.twig... Applied patch README.md cleanly. Applied patch feedback_ai.info.yml cleanly. Applied patch feedback_ai.libraries.yml cleanly. Applied patch feedback_ai.routing.yml cleanly. Applied patch feedback_ai.services.yml cleanly. Applied patch src/Form/FeedbackAIForm.php cleanly. Applied patch src/Plugin/Block/FeedbackAIBlock.php cleanly. Applied patch src/Plugin/Block/SentimentChartBlock.php cleanly. Applied patch src/Plugin/views/filter/FeedbackAiDateBase.php cleanly. Applied patch templates/feedback-ai-block.html.twig cleanly. Applied patch templates/feedback-ai-price-modal.html.twig cleanly. Applied patch templates/sentiment-chart.html.twig cleanly. ā feedback_ai git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml feedback_ai FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/feedback_ai/css/feedback_ai.css ---------------------------------------------------------------------------------------------------- FOUND 28 ERRORS AFFECTING 18 LINES ---------------------------------------------------------------------------------------------------- 3 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 16 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 21 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 22 | ERROR | [x] Expected 1 space after colon in style definition; 2 found 25 | ERROR | [x] Selectors must be on a single line 26 | ERROR | [x] Blank lines are not allowed between class names 26 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 32 | ERROR | [x] Selectors must be on a single line 33 | ERROR | [x] Blank lines are not allowed between class names 33 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 37 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 38 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6 57 | ERROR | [x] Selectors must be on a single line 58 | ERROR | [x] Blank lines are not allowed between class names 58 | ERROR | [x] Expected 1 space before opening brace of class definition; newline found 59 | ERROR | [x] Expected 1 space after colon in style definition; 0 found 59 | ERROR | [ ] Style definitions must end with a semicolon 61 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 61 | ERROR | [x] Opening brace should be the last content on the line 61 | ERROR | [x] Closing brace of class definition must be on new line 62 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 62 | ERROR | [x] Opening brace should be the last content on the line 62 | ERROR | [x] Closing brace of class definition must be on new line 68 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 68 | ERROR | [x] Opening brace should be the last content on the line 68 | ERROR | [x] Closing brace of class definition must be on new line 70 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found 82 | ERROR | [x] Expected 1 space before opening brace of class definition; 0 found ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 27 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- Time: 516ms; Memory: 12MB ā contrib git:(main) āPlease check and advise.
Thank you. - Status changed to Needs review
7 months ago 8:09am 4 July 2024 - š®š³India dev2.addweb
Hi @cleavinjosh,
Thanks for review. I have fixed the issues as you mentioned. Please review it
- Status changed to RTBC
7 months ago 8:24am 4 July 2024 - šµšPhilippines cleavinjosh
Hi @nilesh.addweb,
I applied MR!1 and it was applied cleanly. It also fixes the issues I found last time.
ā feedback_ai git:(1.0.x) curl https://git.drupalcode.org/project/feedback_ai/-/merge_requests/1.diff | git apply -v % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 20588 0 20588 0 0 45300 0 --:--:-- --:--:-- --:--:-- 45348 Checking patch README.md... Checking patch css/feedback_ai.css... Checking patch feedback_ai.info.yml... Checking patch feedback_ai.libraries.yml... Checking patch feedback_ai.routing.yml... Checking patch feedback_ai.services.yml... Checking patch src/Form/FeedbackAIForm.php... Checking patch src/Plugin/Block/FeedbackAIBlock.php... Checking patch src/Plugin/Block/SentimentChartBlock.php... Checking patch src/Plugin/views/filter/FeedbackAiDateBase.php... Checking patch templates/feedback-ai-block.html.twig... Checking patch templates/feedback-ai-price-modal.html.twig... Checking patch templates/sentiment-chart.html.twig... Applied patch README.md cleanly. Applied patch css/feedback_ai.css cleanly. Applied patch feedback_ai.info.yml cleanly. Applied patch feedback_ai.libraries.yml cleanly. Applied patch feedback_ai.routing.yml cleanly. Applied patch feedback_ai.services.yml cleanly. Applied patch src/Form/FeedbackAIForm.php cleanly. Applied patch src/Plugin/Block/FeedbackAIBlock.php cleanly. Applied patch src/Plugin/Block/SentimentChartBlock.php cleanly. Applied patch src/Plugin/views/filter/FeedbackAiDateBase.php cleanly. Applied patch templates/feedback-ai-block.html.twig cleanly. Applied patch templates/feedback-ai-price-modal.html.twig cleanly. Applied patch templates/sentiment-chart.html.twig cleanly. ā feedback_ai git:(1.0.x) ā .. ā contrib git:(main) ā phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml feedback_ai ā contrib git:(main) āI am now moving this to Reviewed & tested by the community.
Thank you. - š®š³India medha kumari Jaipur
medha kumari ā changed the visibility of the branch 3458504-fix-phpcs-issues to hidden.
- š®š³India medha kumari Jaipur
medha kumari ā changed the visibility of the branch 3458504-fix-phpcs-issues to active.
-
nilesh.addweb ā
committed b99d1371 on 1.0.x
#3458504 fixed remaing issues.
-
nilesh.addweb ā
committed b99d1371 on 1.0.x
-
nilesh.addweb ā
committed 17d800dc on 1.0.x
#3458504 added dependency injection in blocks.
-
nilesh.addweb ā
committed 17d800dc on 1.0.x
-
nilesh.addweb ā
committed 151035cb on 1.0.x
#3458504 fixed phpcs issues.
-
nilesh.addweb ā
committed 151035cb on 1.0.x
- Status changed to Fixed
4 months ago 1:37pm 18 September 2024 - Status changed to Fixed
4 months ago 5:29am 19 September 2024