Add icon for vertical dragging

Created on 30 June 2024, 2 months ago
Updated 20 July 2024, about 2 months ago

Problem/Motivation

While testing the prototype of Starshot I've noticed that on pages like admin/structure/block that only allow vertical dragging the icons for vertical/horizontal dragging are used. Drupal Core introduced an icon for vertical dragging in 10.3.0: ✨ Differentiate visually dragging with and without hierarchy Needs work . I've checked in 4.0.x-dev as well but there the vertical/horizontal drag icons are also used.

Steps to reproduce

A few examples for pages with only vertical drag icons:

  • admin/structure/block
  • admin/config/content/formats
  • admin/config/regional/language/detection
  • admin/structure/taxonomy
  • admin/people/roles

Proposed resolution

Adding an icon for vertical dragging

Remaining tasks

User interface changes

API changes

Data model changes

πŸ“Œ Task
Status

Fixed

Version

4.0

Component

User interface

Created by

πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

Live updates comments and jobs are added and updated live.
  • Usability

    Makes Drupal easier to use. Preferred over UX, D7UX, etc.

Sign in to follow issues

Comments & Activities

  • Issue created by @rkoller
  • Status changed to Fixed 2 months ago
  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    @rkoller thanks for reporting, it's now supported πŸ‘Œ

  • Status changed to Needs work 2 months ago
  • πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

    Thanks for the quick fix. I've tested with 4.0.x on macOS 14.5. Problem is with the latest Firefox and Edge the vertical drag icon is correctly displayed, BUT in Safari 17.5 the display is broken:

    Setting the issue back to needs work.

  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    I've tested this in Safari and it looks like expected. You might need to clear your cache.

  • πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

    i run drush cr after every composer update. I did now another time and also pressed the reload button with a pressed alt key in safari. still the same display of the icon :/

  • Status changed to Fixed 2 months ago
  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    Tried it once again with native Safari 17.3 & 18.0 and Safari 16.5, 17.3 in Browserstack and I can't reproduce this. So I'll close this issue again as fixed.

  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    Do you use AdvAgg by any chance? If you you might want to have a look at https://www.drupal.org/docs/contributed-themes/gin-admin-theme/known-iss... β†’

  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    Adding credit

  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich
  • πŸ‡©πŸ‡ͺGermany rkoller NΓΌrnberg, Germany

    no i am not using AdvAgg on any of the test instances here. i have to note that the instance the screenshot was created on is on 11.x. i went ahead and added gin to a drupal 10.3 site. there the vertical drag icon was correctly displayed. next i've tried to add it to another instance also on 11.x, there the vertical drag icon was also correctly displayed. the only odd thing was that the instance i took the screenshot on was still sticking to that broken display of the icon. :/ i've already tried to clear the caches several times with no effect as i've mentioned. i can't explain why cuz technically it couldnt be related but on the status reports page i noticed a warning that the navigation module and the toolbar module are both installed but the former is replacing the latter. so i uninstalled the toolbar module. after the uninstall the vertical drag icon was displayed correctly now. but no idea at all why that uninstall could fix the display of that completely unrelated icon?! are on uninstall more or other "caches" being cleared than with "drush cr"? just trying to figure out what was causing this behavior.

  • πŸ‡¨πŸ‡­Switzerland saschaeggi Zurich

    Still potentially a browser cache issue, SVGs get cached pretty heavily sometimes. Also the svg itself might not be affected by Drupal's caching system.

  • πŸ‡ΊπŸ‡ΈUnited States greenSkin

    I'm seeing the same thing as rkoller. I've cleared Drupal cache and have browser caches disabled in dev tools. Tried in latest Chrome and Safari.

  • πŸ‡ΊπŸ‡ΈUnited States greenSkin

    Tested latest 3.x-dev branch and the icon shows correctly there, so there's something in the dev release that is missing from the MR when applied to RC12.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024