MaterialIcons::getFormIconField assumes depth of icon field

Can confirm this is happening to me too, trying to track down the cause, don't hold your breath.

Well I haven't found out *why* the array keys are not in the positions this module expects them to be on a particular request, but I have found a way to prevent the error, which doesn't affect the widget's behaviour as far as I can tell.

It seems with the !is_null( there are times when the $parents variable is expected to be unavailable, so I think it's reasonable to assume that maybe in some situations it will be available but not in exactly the expected format. So I've made an MR to use a null coalesce operator instead of only checking the main variable.

The same may well be applied at line 195 but I wanted to keep the initial MR to the scope defined within the issue.

In the case I'm looking at the issue is that the icon field is nested within a paragraph field. There may be other issues with the logic in this function that the provided patch would work for, but it does not solve for every case.

You're absolutely right, for one thing we need to retain the null check on the parent variable. I've added a commit to that effect.

This does work for me for a field nested within paragraphs, are you saying it didn't work for you?

It doesn't solve the issue I'm seeing, the paragraph is on a block content entity where I'm investigating which could be related

Pushed progress on fixing this, problems identified:
- Assumes the nested depth of form field in form, this is not true if in paragraphs.
- Tries to return a field value as an ajax response, must be render array for field or ajax command.

I haven't fully solved the second issue yet, so leaving as "needs work" for now. It no longer errors on style value change, but the icon value is yet not updated successfully.

Fixed ajax issue, marking as needs review.

I tested out a patch from the latest diff of the MR, in my situation there was still an error:

An AJAX HTTP error occurred.
HTTP Result Code: 200
Debugging information follows.
Path: /node/8321/edit?destination=/admin/content&ajax_form=1&_wrapper_format=drupal_ajax
StatusText: parsererror
ResponseText: 
Warning:  Trying to access array offset on value of type null in /var/www/html/docroot/modules/contrib/material_icons/src/Plugin/Field/FieldWidget/MaterialIcons.php on line 211

A difference might be that https://www.drupal.org/project/paragraphs_browser → is in use on this site.

Sorry about that, just pushed a fix.

All good man, no apologies please - we're all in this together :)

I've tried out the latest code and at least on that project, it passes manual testing. I don't think that's enough to call it reviewed, but it's a start.

vladimiraus → changed the visibility of the branch 2.0.x to hidden.

exit stops the program. To exit the loop, use break.

vladimiraus → changed the visibility of the branch 3457701-getfontfamily-ajax-error to hidden.

vladimiraus → changed the visibility of the branch 3457701-getfontfamily-ajax-error to active.

Fixed PHPCS violations and replaced exit with break.

Looks good. 👍

I'm having a hard time recreating this. I've tried inside a paragraph on a block inside Layout builder and not seeing any errors. Can you provide a step by step?

Nevermind, found it, but I think this is wayyyy over architecting. Let me try something new here.

b_sharpe → changed the visibility of the branch 3457701-getfontfamily-ajax-error to hidden.

Much cleaner using NestedArray::getValue().

Please review.

Code looks good - I'm afraid I don't have access to the projects I was using this on any more so I can't try it out.