- Issue created by @joegraduate
- Merge request !15Issue #3456892 by joegraduate: GitLabCI: Fix existing PHPStan issues β (Merged) created by joegraduate
- Issue was unassigned.
- Status changed to Needs review
6 months ago 1:57am 25 June 2024 - πΊπΈUnited States joegraduate Arizona, USA
Created MR !15 that:
- Adds a
@phpstan-ignore
comment inDrupal\config_distro\Form\ConfigDistroImportForm
to ignore error about extending an internal class since we are knowingly doing so. - Removes code for supporting Drupal core <8.6 since the 2.0.x branch no longer supports D8 (see [#https://www.drupal.org/project/config_distro/issues/3000886]).
I also created a separate issue for exploring alternative implementations for
ConfigDistroImportForm
that don't require extending an internal class ( π Explore alternatives to extending internal core ConfigSync form class Active ). - Adds a
- Status changed to RTBC
6 months ago 11:08pm 25 June 2024 - πΊπΈUnited States trackleft2 Tucson, AZ πΊπΈ
This looks good to me RTBC
My only thought was that we could add a test to determine whether the proper events are fired, but that can be a follow-up or part of the " Create Rigorous Tests π Create rigurous tests Needs review " ticket.
-
joegraduate β
committed c4ab9be3 on 2.0.x
Issue #3456892 by joegraduate, trackleft2: GitLabCI: Fix existing...
-
joegraduate β
committed c4ab9be3 on 2.0.x
- Status changed to Fixed
6 months ago 10:14pm 26 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.