- Issue created by @heddn
- π¦π·Argentina tongadall
Note for anyone who needs to know how to apply the patches, add these patches to composer.json:
"extra": { ... "patches": { "drupal/cl_editorial": { "#3456850: Support Drupal 10.3 SDC deprecation": "https://www.drupal.org/files/issues/2024-07-01/3456850-3.patch" }, "drupal/sdc_block": { "#3456851: Support Drupal 10.3 SDC deprecation": "https://git.drupalcode.org/project/sdc_block/-/merge_requests/3.patch" } }, },
And execute:
composer update drupal/cl_editorial drupal/sdc_block
The patches are not working on my system.
I went installed sdc_block, after sdc_display, patches applied. Enabling sdc_block, makes my site not work. Error below.
Uninstall, removing the whole lot (sdc_display & sdc_block, the site comes back. Starting with sdc_block, install, patches apply, enable β¦ crash. Uninstall, remove, comes back.
I can install sdc_display, apply patches, enable and the site works.
[30-Jul-2024 10:00:16 America/Los_Angeles] Uncaught PHP Exception Drupal\Core\Render\Component\Exception\InvalidComponentException: "[props.title] Object value found, but a string is required" at /Users/todd/Sites/btc-d10/public_html/core/lib/Drupal/Core/Theme/Component/ComponentValidator.php line 121
- Status changed to Needs review
about 1 month ago 9:05pm 5 November 2024 - πΊπΈUnited States boyerj
I was able to get the patches to work by also changing the constraint on sdc_tags which is a submodule of cl_editorial.
In my install, sdc_block is pulling in cl_editorial version 2.0.0-rc1. In this version, sdc_tags version constraint is
^9 || ^10 < 10.3
and does not allow 10.3. Once I changed that value tocore_version_requirement: ^9 || ^10.3
( and had the patches in #4 applied) I re-enabled sdcdrush pm:enable sdc sdc_block
and it worked in the same way as Drupal 10.2.I'm working on rolling a patch.
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
^9 || ^10.3
is not likely to ever be correct. If it needs 10.3, it won't work on Drupal 9. - heddn Nicaragua
Is there some work needed on MR 3? Or can we mark it RTBC?
- π¨π¦Canada Liam Morland Ontario, CA π¨π¦
Looks good to me.
The problem with
cl_editorial
is fixed by moving to the new version ofcl_editorial
. That is done in π Update dependency on cl_editorial Active .