Temporary folder full with temporary files

This is an initial patch, but is already working

Did few updates on patch #2

• Added / Improved comments
• Fixed coding standards
• Minor improvements for code reading and future maintainability

To be easier to review I created a Merge Request: https://git.drupalcode.org/project/imagick/-/merge_requests/10

MR updated pointing to the dev branch

If someone needs, Just attached a patch with target for version 1.6 stable so it can be applied though composer

Necessary to update the service to get dynamically from temp folder

MR updated pointing to the dev branch

If someone needs, Just attached a patch with target for version 1.6 stable so it can be applied though composer

Moving to NR to apply the suggestion above

Thank you for your great work, this really should be included, and needs info on the module readme.
We have developed a DAM system for our clients based on Drupal. Imagick is used for lots of things, for example to convert selected assets to lower-res versions or to other image formats.
Since one of our DAM systems was reaching the hosting storage limit, I started investigating by getting the top 5 biggest folders via following ssh command:
du -Sh | sort -rh | head -5

Then I immediatly saw that the tmp folder was 96GB, which is very large. It contained lots and lots of /magick-... files.
I patched the imagick module with this MR, enabled the garbage collector, deployed these changes and ran cron.
Result is that our tmp folder has been reduced from 96GB to 2GB.
Needless to say, I am very happy with this functionality.

Thanks for sharing your feedback @flyke

I've update the MR with the following:

• * merged in the latest changes from 8.x-1.x so there are no merge conflicts at time of writing
• * fixed the config type values in the imagick.config.yml
• * added the missing properties to the imagick.schema.yml
• * made the suggested change of moving (and modifying) the check to skip processing if garage collector is disabled, into hook_cron instead of being within the service itself.

made the suggested change of moving (and modifying) the check to skip processing if garage collector is disabled, into hook_cron instead of being within the service itself

Appreciated

Seems really good, but as suggested on #12 I think would be nice if we update the README.md with this functionality

Added the README.md as suggested on #12

I think the MR does not apply anymore to the latest 8.x-1.x-dev ?

Really? 🤔

For me it's appearing as mergeable ( ref )

Ready to merge by members who can write to the target branch

Screenshot attached:

Latest changes in the MR look good! Marking as RTBC

Hey folks, this MR needs to reroll, because phpcs, phpstan, etc issues were fixed before. Thanks!

prem suthar → made their first commit to this issue’s fork.

prem suthar → closed merge request !20

prem suthar → closed merge request !21

MR Merged with '8.x-1.x'

Ah, sorry @renatog, please rebase MR to 2.x branch

Ah, sorry @renatog, please rebase MR to 2.x branch

Got it, no problems

It's done!
MR rebased and now the target points to 2.0.x

I really rebase MR to 2.0.x and now MR is totally broken (it's wants to remove all 2.0.x fixes) -_-

I didn't download patch from MR before I rebased :(

@renatog, could you attach the patch for me (from your local) ? I want to create a new branch from 2.0.x and create a new MR

Sure! I’m on it

Just a rerolled patch for 1.12 based on #10. Leaving as NW in order to apply it to 2.x

@renatog ping :)

Ok, I will use patch #10 and commits after that

ivnish → closed merge request !10

I recreated MR for 2.x branch from patch. Please review and test

Thanks @ivnish, we've been using the version 1.x here, but the patches/mr are basically the same, I just left two minor comments. The code looks good to me! Moving back to NW.