- Issue created by @renatog
- Status changed to Needs review
5 months ago 4:56pm 24 June 2024 - π§π·Brazil renatog Campinas
This is an initial patch, but is already working
- Merge request !10Issue #3456804 by renatog: Temporary folder full with temporary files β (Open) created by renatog
- π§π·Brazil renatog Campinas
Did few updates on patch #2
- Added / Improved comments
- Fixed coding standards
- Minor improvements for code reading and future maintainability
To be easier to review I created a Merge Request: https://git.drupalcode.org/project/imagick/-/merge_requests/10
- π§π·Brazil renatog Campinas
MR updated pointing to the dev branch
If someone needs, Just attached a patch with target for version 1.6 stable so it can be applied though composer
- Status changed to Needs work
5 months ago 4:56am 5 July 2024 - π§π·Brazil renatog Campinas
Necessary to update the service to get dynamically from temp folder
- Status changed to Needs review
5 months ago 5:16am 5 July 2024 - π§π·Brazil renatog Campinas
MR updated pointing to the dev branch
If someone needs, Just attached a patch with target for version 1.6 stable so it can be applied though composer
- Status changed to Needs work
5 months ago 1:53pm 5 July 2024 - π§πͺBelgium flyke
Thank you for your great work, this really should be included, and needs info on the module readme.
We have developed a DAM system for our clients based on Drupal. Imagick is used for lots of things, for example to convert selected assets to lower-res versions or to other image formats.
Since one of our DAM systems was reaching the hosting storage limit, I started investigating by getting the top 5 biggest folders via following ssh command:
du -Sh | sort -rh | head -5
Then I immediatly saw that the tmp folder was 96GB, which is very large. It contained lots and lots of /magick-... files.
I patched the imagick module with this MR, enabled the garbage collector, deployed these changes and ran cron.
Result is that our tmp folder has been reduced from 96GB to 2GB.
Needless to say, I am very happy with this functionality. - π§π·Brazil renatog Campinas
Thanks for sharing your feedback @flyke
- First commit to issue fork.
- π¬π§United Kingdom rossb89 Bristol
I've update the MR with the following:
- * merged in the latest changes from 8.x-1.x so there are no merge conflicts at time of writing
- * fixed the config type values in the imagick.config.yml
- * added the missing properties to the imagick.schema.yml
- * made the suggested change of moving (and modifying) the check to skip processing if garage collector is disabled, into
hook_cron
instead of being within the service itself.
- π§π·Brazil renatog Campinas
made the suggested change of moving (and modifying) the check to skip processing if garage collector is disabled, into hook_cron instead of being within the service itself
Appreciated
Seems really good, but as suggested on #12 I think would be nice if we update the README.md with this functionality
- π§π·Brazil renatog Campinas
Added the README.md as suggested on #12