[regression] Entity view block not displayed after #2962166

Ok, it seems metatag gets the [node:summary] token which increments the recursion counter. I guess that makes sense.
MR opened, and static composer patch attached.

Whoops, I made a silly mistake with the logger... disregard patch #5.
Also fixing pre-existing cspell and phpcs issues in EntityView.php.

I was experiencing a similar issue that only started happening after Drupal 10.3.0 where a ctools node block was not being rendered on the same page as the full node view.

This patch seems to fix that for me. Thanks!

Patch #6 worked for me. Raised issue to Major since it will affect any site using the popular Diff module. Without the patch, the render of the second revision in the Diff comparison fails since the same node is rendered twice in a single page view. This makes it look like the second revision deleted all the content.

Patch #6 worked for me as well.

Note that the recursion detection is still not very good.
Maybe we could borrow the same approach as 🐛 Can only intentionally re-render an entity with references 20 times Needs work ?

For now couldn't we revert the changes from the issue that introduced this regression?

I pushed a better/proper recursion detection logic, with a similar logic than 🐛 Can only intentionally re-render an entity with references 20 times Needs work .

PS: the pipeline on 3.x is currently broken.

herved → changed the visibility of the branch 3456722-regression-entity-view to hidden.

Snapshot of current MR, for composer.