- Issue created by @reinfate
- Merge request !8518Issue #3456676: Single Directory Components templates are not auto reloaded after change → (Open) created by reinfate
- Status changed to Needs review
9 months ago 11:29am 24 June 2024 - Status changed to Needs work
9 months ago 1:58pm 25 June 2024 - 🇺🇸United States smustgrave
Nice catch!
Feel this is something we should probably have test coverage for.
- Merge request !10244Issue #3456676: Single Directory Components templates are not auto reloaded after change → (Closed) created by reinfate
Added the test coverage for the
isFreshfunction inComponentLoaderI've removed the yml file change check, it is not needed, since the component schema will be refreshed only after the discovery cache clear anyway.
The test failures seem to be not related to this issue. I've rerun them multiple times on 11.x and 11.1.x branches, and each time different test was failed.
- Status changed to Needs review
about 1 month ago 5:44pm 31 January 2025 - 🇫🇷France Grimreaper France 🇫🇷
Hi,
Thanks for the bug report and the fix, I also witnessed this behavior to be in Twig debug mode and not have component refreshed after change in Twig.
Tested ok.
I just put one question on MR, so not RTBC for that.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
I think if we're enabling
twig.config:auto_reloadi would expect changes to the yml or the template to result in changes automatically. Made a suggestion to make it work this way. I don't see why we need to check the YML file.
The class is responsible specifically for the component's twig file.
Even if we assume that the YML discovery cache is disabled, the YML file itself doesn't affect the twig compilation in any way.
Unless the changes are in the twig file itself it shouldn't be recompiled therefore it is fresh.