- Issue created by @seanB
- Status changed to Needs review
6 months ago 1:04pm 23 June 2024 - Merge request !8505Issue #3456528: _node_mass_update_batch_process fails during user cancel when revision is deleted → (Open) created by seanB
- Status changed to Needs work
6 months ago 3:14pm 23 June 2024 - Assigned to ankitv18
- 🇺🇸United States smustgrave
Would let @seanB update the existing branch before we start opening bunch of new ones, since it's only been 1 hour.
- Issue was unassigned.
- 🇮🇳India ankitv18
Alright @smustgrave
@seanB could you try below code whether it's resolving the problem instead of if condition with instanceOf check.
/** @var \Drupal\node\NodeStorageInterface $storage */ $storage = \Drupal::entityTypeManager()->getStorage('node'); $count = min(5, count($context['sandbox']['nodes'])); for ($i = 1; $i <= $count; $i++) { // For each nid, load the node, reset the values, and save it. /** @var \Drupal\node\NodeInterface $node */ $node = array_shift($context['sandbox']['nodes']); if ($load) { $node = $revisions ? $storage->loadRevision($node) : $storage->load($node); } $node = _node_mass_update_helper($node, $updates, $langcode);
- Merge request !8515Issue #3456528: Fix _node_mass_update_batch_process fails. → (Open) created by ankitv18
- Status changed to Needs review
6 months ago 10:58am 24 June 2024 - 🇮🇳India ankitv18
MR!8515 is ready for a review
@seanB could you please check MR!8515 and check whether this resolve the issue.
cc: @smustgrave - Status changed to Needs work
6 months ago 1:57pm 25 June 2024 - 🇺🇸United States smustgrave
Would much rather of given @seanB a chance to update his MR, so now we got 2 one needs to be hidden.
The latest MR does not match the summary.
Tagging for tests based on the title, seems like a bug we should have coverage for.
- 🇳🇱Netherlands seanB Netherlands
MR!8515 does not solve the issue. If a node or revision is deleted during the batch process (by something or someone outside of the batch process),
$node
is NULL. This throws an error when trying to call_node_mass_update_helper
.