- Issue created by @wmfinck
- π¦πΊAustralia darvanen Sydney, Australia
That sounds like config validation might be the cause. I'm not 100% sure how that works with text filters, the setting is mentioned in the Annotation of the text filter plugin but maybe it needs to be in the schema file too?
If it's blocking changes then I reckon this is Major.
- π¦πΉAustria FloGe
I got the same error. Adding the key to the schema.yaml fixed it for me.
- Status changed to Needs review
6 months ago 8:50am 23 June 2024 - π¦πΊAustralia darvanen Sydney, Australia
Fantastic, thanks @FloGe.
Code looks good to me, just want another report of manual testing and I'll push it out.
- πΊπΈUnited States wmfinck
This morning I added the lines from the patch in #3, cleared the cache, and it worked on both of the affected websites.
Thank you very much, especially for the quick solution!
- Assigned to darvanen
- Status changed to RTBC
6 months ago 10:41pm 23 June 2024 - π¦πΊAustralia darvanen Sydney, Australia
I'll call that RTBC then, just gonna turn this into an MR so we can run the pipeline.
-
darvanen β
committed f48d00bb on 2.x
Issue #3456459 by darvanen, FloGe, wmfinck: 'replace_empty' is not a...
-
darvanen β
committed f48d00bb on 2.x
- Status changed to Fixed
6 months ago 10:54pm 23 June 2024 - π¦πΊAustralia darvanen Sydney, Australia
Fixed on 2.x, also cherry-picked to new 2.1.x but that isn't showing up here because it's not a development release yet. Release to follow.
- π¦πΊAustralia darvanen Sydney, Australia
Thanks very much to both of you, hopefully this won't be too disruptive for others now.
- π©πͺGermany Anybody Porta Westfalica
Thank you very much @darvanen. For when is a release planned? We've also encountered this with the latest "stable" release now.
- π¦πΊAustralia darvanen Sydney, Australia
@Anybody the one I pushed out two days ago? That includes this fix, or so I thought. Can I check which version you're running and whether it has the additional schema in it?
- π©πͺGermany Anybody Porta Westfalica
@darvanen thank you! I'll check that! I just compared the dates and the fix here was from June 24 while the release page says: "2.2.1 released 23 June 2024"
I'll check that now!
- π©πͺGermany Anybody Porta Westfalica
@darvanen sorry all good! I was confused by the date! The remaining issues are now from other modules. I'll reference this issue there for the appropriate fix! :)
Great work!
- π¦πΊAustralia darvanen Sydney, Australia
Brilliant, glad to hear it, thanks for following up.
I think what happened there is the module page doesn't get translated to local timezones the way comments do.
- πͺπΈSpain taote
I don't know why the patch is not working for me. Patch applied, cache emptied and same error.
- π¦πΊAustralia darvanen Sydney, Australia
@taote which version are you working with? This has already been released two weeks ago.
If it's still happening can you open a new issue with the exact problem and how to reproduce it on a fresh site install with just the relevant modules (token and token_filter) in play?
- πͺπΈSpain taote
Fixed darvanen.
I don't know why the modules that I have installed via composer inside a folder called contrib in modules, they were duplicated inside another folder called custom. So I think Drupal was using the wrong module version.
- Issue was unassigned.
- Status changed to Fixed
5 months ago 1:42am 12 July 2024 - π¦πΊAustralia darvanen Sydney, Australia
Composer puts contrib modules there if your composer.json file contains this, which most standard projects do:
Perhaps someone copied them into custom in order to alter them and forgot to remove them from composer? Glad it's been sorted for you.