10.3.x patch code removed in #079b12ca

Created on 21 June 2024, 7 days ago
Updated 26 June 2024, 2 days ago

Problem/Motivation

10.3.x patch code was completely wiped/removed/emptied on June 4th in commit #079b12ca (079b12ca7d87949b2bd7b35586d3eaa94c3a61f0): https://git.drupalcode.org/project/distributions_recipes/-/commit/079b12...

Steps to reproduce

Open the 10.3.x patch to see it's empty:

  1. https://git.drupalcode.org/project/distributions_recipes/-/raw/patch/rec...
  2. https://git.drupalcode.org/project/distributions_recipes/-/blob/patch/re...
πŸ› Bug report
Status

Closed: works as designed

Version

10.3

Component

Code

Created by

πŸ‡±πŸ‡»Latvia Phonoman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Phonoman
  • Status changed to Closed: works as designed 6 days ago
  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    The patch is not currently needed as the recipes functionality is in core. All the functionality you need is available without the patch.

    We have not made additional changes, so the patch is empty. The initiative may continue to commit larger efforts to this project where the patch will be helpful. There are just no changes at this time.

    Closing this issue as works as designed.

  • πŸ‡±πŸ‡»Latvia Phonoman

    Thanks for the reply and explanation!
    In that case, I'd probably suggest adjusting the module description - by adding a comment that recipes are now baked in at least for the 10.3.x version - to have that instantly clear when one is upgrading the core and glancing over the module when the previous patch fails. :)

  • πŸ‡ΊπŸ‡ΈUnited States thejimbirch Cape Cod, Massachusetts

    This is not a module.

    The project page was previously updated to say:

    To use Drupal recipes in 10.3 and above, you no longer need to patch, you can just use the functionality in core. Patches remain available here for Drupal 10.2 and for ongoing development work.

    I am not sure where else it could be said.

  • πŸ‡±πŸ‡»Latvia Phonoman

    Wow, I must've been totally blind or it was way too late when I last looked at the page, my bad!
    I initially looked at the 10.3.x patch entry and since I saw a patch ready, just took it without taking a look at it. I would've noticed the note instantly if it was right there (or maybe like an asterisk next to the version "*10.3.x" and then reference the asterisk to the note you mentioned).
    But, either way - it was a user error as I just totally missed that paragraph in-between the page somehow and if anyone else does the same, they'll now see this issue, so win-win? :)

    Sorry for taking up your time and unintentionally roleplaying as a UX tester in a rush. πŸ˜…

Production build 0.69.0 2024