[2.x] Views table search

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. master is a wrong name for a branch. Release branch names always end with the literal .x as described in Release branches → .

2. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml views_tablesearch/

FILE: views_tablesearch/README.md
----------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
  3 | WARNING | Line exceeds 80 characters; contains 355 characters
  5 | WARNING | Line exceeds 80 characters; contains 152 characters
 17 | WARNING | Line exceeds 80 characters; contains 159 characters
 19 | WARNING | Line exceeds 80 characters; contains 497 characters
----------------------------------------------------------------------

FILE: views_tablesearch/src/Plugin/views/style/TableSearch.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 319 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
----------------------------------------------------------------------

Hello @vishal.kadam, thank you for your reply

The issues have been fixed, the master branch has been deleted and phpcs issues have been fixed also

Regards

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

• The following points are just a start and don't necessarily encompass all the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that does not follow the coding standards, contains possible security issues, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

views_tablesearch.theme.inc

The content of this file must be moved in the .module file; the code in the module file that is outside any function must be removed.
Drupal load modules before they could execute code; any code outside functions or classes would be executed causing errors.

src/Plugin/views/style/TableSearch.php

The class uses a base class, which is public API, as parent class. 👍

  /**
   * Does the style plugin for itself support to add fields to it's output.
   *
   * @var bool
   */
  protected $usesFields = TRUE;

That property is already defined from the parent class, but since the code is initializing the property using a different value used by the parent class, this should be allowed.
Still, the documentation code must be like the one used for inherited methods.

  /**
   * {@inheritdoc}
   */
  protected $usesRowPlugin = FALSE;

In this case, the property (already defined from the parent class) use the same initialization value used by the parent class. That property definition can be removed.

  /**
   * Does the style plugin support custom css class for the rows.
   *
   * @var bool
   */
  protected $usesRowClass = TRUE;

  /**
   * Should field labels be enabled by default.
   *
   * @var bool
   */
  protected $defaultFieldLabels = TRUE;

  /**
   * DefineOptions.
   */
  protected function defineOptions() {
    $options = parent::defineOptions();

    $options['columns'] = ['default' => []];
    $options['default'] = ['default' => ''];
    $options['info'] = ['default' => []];
    $options['override'] = ['default' => TRUE];
    $options['sticky'] = ['default' => FALSE];
    $options['order'] = ['default' => 'asc'];
    $options['caption'] = ['default' => ''];
    $options['searchlabel'] = ['default' => $this->t('Search')->render()];
    $options['characters'] = ['default' => '3'];
    $options['highlight_color'] = ['default' => '#ccc'];
    $options['summary'] = ['default' => ''];
    $options['description'] = ['default' => ''];
    $options['empty_table'] = ['default' => FALSE];

    return $options;
  }

Those documentation comments must be like the ones used for inherited methods.

templates/views-view-tablesearch.html.twig

{% if case_sensitive_search %}
{% set checked = 'checked="checked"' %}
{% else %}
{% set checked = '' %}
{% endif %}

Code needs to be correctly indented.

Hello @apaderno

Thank you for reviewing the module

I made the corrections can you please recheck?

Thanks in advance

I am changing priority as per Issue priorities → .

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.