Hook "moderated_content_bulk_publish_verify_publish" doesn't work

Hello,
There's really the issue and MR 25 completely works for me. Also langcode and bundle properties look necessary there.
Thanks

Nice work on this

Can we get it rolled for 2.0.x also please?

sure, @joseph.olstad will do.

gaurav_manerkar → changed the visibility of the branch 3455569-publish-hook-doesnt-work-2.0.x to hidden.

gaurav_manerkar → changed the visibility of the branch 3455569-publish-hook-doesnt-work-v2 to hidden.

gaurav_manerkar → closed merge request !26

MR prepared -
2.0.x - https://git.drupalcode.org/project/moderated_content_bulk_publish/-/merg...
3.0.x https://git.drupalcode.org/project/moderated_content_bulk_publish/-/merg...

Thanks!

Updated both MR's.
Please review and test.

MR27 works fine for version 2.0.x aswell and the hook starts working for content without a body field.

joseph.olstad → closed merge request !27

joseph.olstad → closed merge request !25

d.o merge request process could be improved, they won't let you merge if the pipeline doesn't run, so I added .gitlab-ci.yml, but it wouldn't run that because it wasn't in the merge request. Then, there's no obvious way to click to bring the merge request up to date with the destination branch. So I did cherry picks instead and closed the merge requests.

https://www.drupal.org/project/moderated_content_bulk_publish/releases/2... →

https://www.drupal.org/project/moderated_content_bulk_publish/releases/3... →

[#3457631]
[#3457633]

Hi @joseph.olstad

Please provide issue credit.

Commit c503a098 authored 1 week ago by Gaurav Manerkar Committed by Joseph Olstad 4 hours ago
Issue #3455569 by gaurav_manerkar, joseph.olstad mr_fenix: Hook 'moderated_content_bulk_publish_verify_publish' doesn't work when no body field.

Your name is on this twice, once as author, another as by and then again, for the issue fixed you'll get credit also. X2 for both commits

Commit c21af052 authored 1 day ago by Gaurav Manerkar Committed by Joseph Olstad 4 hours ago
Issue #3455569 by gaurav_manerkar, joseph.olstad mr_fenix: Hook 'moderated_content_bulk_publish_verify_publish' doesn't work when no body field.

so you'll be credited 5 times in total.

@guarav_manerkar what credit are you referring to? If you were expecting something other than what I described in comment #26, please let me know.

@joseph.olstad.
I am referring to issue credits.

1. To to issue edit page - https://www.drupal.org/node/3455569/edit →
2. Scroll down to credits section:

3. Tick checkboxes
4. Save

Ah yes , thanks I did so

Sorry my appologies, I didn't realize that the maintainer needs to checkmark those

Automatically closed - issue fixed for 2 weeks with no activity.