- Issue created by @DamienMcKenna
- 🇺🇸United States DamienMcKenna NH, USA
This seems to be a default part of Bootstrap, which is a little silly imho.
https://cdn.jsdelivr.net/npm/bootstrap@5.2.0/dist/css/bootstrap.min.css
table { caption-side: bottom; border-collapse: collapse; }
- First commit to issue fork.
- Open on Drupal.org →Core: 10.1.0-alpha1 + Environment: PHP 7.4 & MySQL 5.7last update
5 months ago Waiting for branch to pass - Status changed to Needs review
5 months ago 12:40pm 17 June 2024 - 🇮🇳India supriyak
Hi Everyone,
This bug is occurring in 'Bootstrap Barrio Subtheme'.
To fix this bug I have raised MR : https://git.drupalcode.org/project/bootstrap_barrio/-/merge_requests/83. Please review it.Thank you!!
- Status changed to Needs work
5 months ago 1:09pm 17 June 2024 - 🇺🇸United States DamienMcKenna NH, USA
Thank you for working on the change.
I believe the Sass files in the "scss" directory need to be the source of the change, and then compile it to produce the changes in the CSS directory.
- Assigned to supriyak
- Open on Drupal.org →Core: 10.1.0-alpha1 + Environment: PHP 7.4 & MySQL 5.7last update
5 months ago Waiting for branch to pass - 🇮🇳India supriyak
Hi @DamienMcKenna,
Thank you for your reply. I have pushed my new changes in same MR.
Please let me know your feedback on this. - Status changed to Needs review
5 months ago 5:38am 18 June 2024 - Status changed to Needs work
5 months ago 9:33am 18 June 2024 - 🇺🇸United States DamienMcKenna NH, USA
After you modify the scss files you then need to compile the theme again, so that your PR will ultimately include both the scss and css file changes.
- 🇮🇳India supriyak
Hi @DamienMcKenna,
I think this theme is not compiled yet.
I have tried to compile the files here. The data in table.css and table.scss is different.
So when I try to compile table.scss, previous data of that file got removed and only new changes are there which is not acceptable.Please suggest me should I add the code in both the files?
Thanks!!
- 🇺🇸United States DamienMcKenna NH, USA
That's a point - there's no configuration provided for compiling the theme, so it's not clear how that's supposed to be done.
I opened another issue asking the maintainers to provide this: 📌 No configuration provided for compiling the theme Active
- Status changed to Closed: works as designed
4 months ago 4:05pm 29 July 2024 - 🇵🇪Peru hatuhay Lima
table-captions works default Drupal.
Forcing captions to appear on top using !important will not let anyone else change their positioning.
If for any case caption top is required on subtheme add class caption-top as explained on Bootstrap docs https://getbootstrap.com/docs/5.3/content/tables/#captions