Improve failure messaging

Created on 14 June 2024, 6 months ago

Problem/Motivation

When a media+file is deleted, and cannot be deleted due to access control reasons, an irrelevant message is shown.

> The file attached to this media is owned by %name so will be retained.

For example, if delete any file denies deletion, the message show is completely irrelevant.

The owner may also be missing, which leads to a calling-method-on-null error.

We should fix this, by adding a more generic access control error, optionally showing the relevant error, and logging the error + reason to logs.

Proposed resolution

Add option to show reason. New sites show it, existing sites do not.
Add a thin + generic configuration service.
Always log the failure and reason to logs.
Modernise forms dependency injection w new autowire trait.
Increase minimum core version (10.2 and later)
Add missing entity usage dependency for tests. See also 📌 Add gitlabci Fixed

Remaining tasks

Review, tests.

User interface changes

New options in config form.
New strings shown to user depending on module configuration

API changes

Services changed, New services, new configuration

Data model changes

New configuration.

Feature request
Status

Needs review

Version

1.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024