TypeError: WorkflowTransitionElement::copyFormValuesToTransition() (line 356) when hiding subfields

Please test dev version, and check] 🐛 Warning : Undefined array key "to_sid" in WorkflowTransitionElement::copyFormValuesToTransition() line 356 when using Ajax button from other field Fixed . Is it the same problem?

I'm encountering an issue applying the patch. It's returning this error on my end:

patch: **** Only garbage was found in the patch input.

   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2024-06-07/workflow_3452716_8_undefined_key.patch

I applied this using composer-patches.

Additionally, i also noticed this. The states are redundant, we have one on the "Edit" tab (How to show the available states), and also one on the "Manage form display tab" (To state). When the "To state" field is shown, It's the one who throws the error i have described in the title. But when i disable it, the states from the "Edit" tab show, but saving the node will throw the following errors:

Warning: Undefined array key 0 in Drupal\workflow\Element\WorkflowTransitionElement::copyFormValuesToTransition() (line 356 of modules/contrib/workflow/src/Element/WorkflowTransitionElement.php).

Warning: Trying to access array offset on value of type null in Drupal\workflow\Element\WorkflowTransitionElement::copyFormValuesToTransition() (line 356 of modules/contrib/workflow/src/Element/WorkflowTransitionElement.php).

Error: content [node id] has no workflow attached. The data is not saved.

This value should not be null.

Regarding comment #4:
Indeed, in /admin/config/workflow/workflow/TYPE, the states are redundant. This is since the elements of the Transition are made customizable. The one in 'Manage form display' should be hidden, and the settings should not be used. I will open a ticket for that.

(Note: There is another issue requesting to have such settings on field basis, not on Workflow basis.)

The steps in 'Steps to fix?' are not to be used IMO. The result will be that you only change the state., without scheduling or comments. For that, you can just use the widget on the node, setting it from TransitionForm to Select.

Regarding MR #8.
Thanks for the contribution.
It seems it is not against latest version. Latest Dev Version is 1.8 + 4 patches.
In the first part (setting fieldnams/sid to NULL), that is already assured in latest commits.
In the second part, I see that some data is missed, when elements are hidden in the Workflow Settings.
Please check attached patch. Sorry for not having learned how MR's work.

Question: are you experiencing this in a new install, or after the upgrade to version 1.8?

I assume the provided patch is OK.
Also, a comment is placed on the 'Manage form display' page, hinting to the unexpected behaviour.
Until now, I did not make that page prevalent, since:
- is does not support 'required'
- needs backporting existing installations
- does not support the 'per formatter' settings.

Please test current dev version and report back if the error has gone in all situations.
I will try to create a new version soon.

#15 - I am yet to test the patch in #11 as it is currently an awkward time in my country to test right now, i will be back with a proper result for later

Okay so, i can't apply the patch file again for some reason, both in dev and in current 8.x, so i cloned the 8.x-1.x branch to my test environment, but i am now encountering a new problem:

TypeError: Drupal\Core\Field\WidgetBase::errorElement(): Argument #1 ($element) must be of type array, null given, called in /var/www/html/web/core/lib/Drupal/Core/Field/WidgetBase.php on line 580 in Drupal\Core\Field\WidgetBase->errorElement() (line 646 of core/lib/Drupal/Core/Field/WidgetBase.php).

This error happens as when creating a node or updating a node using the "To state" field found in the manage form display section

I setup a new user for this as well to test if it is an admin-only problem but the same problem exists.