can not compile startkit.

Created on 13 June 2024, about 1 year ago

Problem/Motivation

1. ui_suite_bootstrap_starterkit does not have any package.json for users of starterkit
2. will a bare package.json, current ui_suite_bootstrap_starterkit is linking to prior bootstrap structure -- npm watch fails.

╷
╷
4 │ @import "../../../../../libraries/bootstrap/scss/functions";
  │         ^^^^^^^^^^^^^^

...
10 │ @import "../../../../../libraries/bootstrap/scss/variables";
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
...
Error: Can't find stylesheet to import.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

5.0

Component

Code

Created by

🇨🇦Canada SKAUGHT

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @SKAUGHT
  • Status changed to Postponed: needs info about 1 year ago
  • 🇫🇷France Grimreaper France 🇫🇷

    Hi,

    1 Generated theme placement:

    As mentioned in https://git.drupalcode.org/project/ui_suite_bootstrap/-/blob/5.0.x/start...

    With the following command, the generated theme is placed in themes/custom.

    php core/scripts/drupal generate-theme my_theme --starterkit ui_suite_bootstrap_starterkit --path themes/custom
    

    2 Compilation:

    I currently don't want to provide a package.json example because with it will come the need to provide task runner file example and there is no standard. Every one has its own on its projects. Some use Gulp, others Webpack, others Grunt, [insert the new trendy task runner], etc. With different configuration.

    It is something that can be added into the starterkit README, that compilation is not supported, it is up to anyone to handle it and/or provide links to examples.

  • 🇫🇷France Grimreaper France 🇫🇷
  • Status changed to Closed: works as designed 11 months ago
  • 🇫🇷France Grimreaper France 🇫🇷

    Closing as there is no reply.

    Feel free to re-open if needed.

  • Hi, I don't want to reopen or start a new issue as I'm still exploring but need to leave a comment/reflection: What's the point of providing a SASS starterkit not supporting compilation and at the same time provide it without compiled CSS files?

    After exploring several bootstrap based themes I find UI Suite Bootstrap being the most interesting, but (and it's a big but) after successfully generating my subtheme from provided SASS starterkit and install it as default I get a whole batch of errors due to missing CSS files where only SCSS files are present.

    This will probably turn off most speculative users and may be a reason why so few sites are reported having this theme installed. So why not provide a set of compiled CSS files based on the SCSS ones or at least provide a CSS based starterkit?

    Also, I'd suggest to give the starterkit a version to make it easier to track future updates/changes.

  • 🇫🇷France Grimreaper France 🇫🇷

    Hi,

    What's the point of providing a SASS starterkit not supporting compilation and at the same time provide it without compiled CSS files?

    The goal is to provide example of how to include the different Bootstrap's SASS files in the correct order to provide customizations. And also how to override the libraries in the info.yml

    So why not provide a set of compiled CSS files based on the SCSS ones or at least provide a CSS based starterkit?

    Because those compiled CSS would be for a specific Bootstrap version and would need to be recompiled and commited at each Bootstrap release.

    Now in the 5.2.x branch, CDN and Bootswatch support are present, so it will drastically ease the setup for demo and evaluation.

    Also, I'd suggest to give the starterkit a version to make it easier to track future updates/changes.

    The starterkit version will correspond to the ui_suite_bootstrap version when packaged by drupal.org and when generating a starterkit from the Core's command, it will note from which version of the starterkit it had been generated. (or does it has changed since the last time I tried this command?)

    I find UI Suite Bootstrap being the most interesting

    Thanks!

    Also feel free to propose improvements into the starterkits with merge request!

  • Sorry for the late reply, I got ill.

    Ok I see your points and understand more now as I was able to explore more and get the SCSS files compiled before I got ill. So all fine there.

    As for the starterkit version, no. I generated with drupal and it made some kind of complaint about the starterkit missing a version number and that it lacking would make it harder to track changes when updating. Unfortunately, I didn't screenshot or wrote down the message.

    I'm just getting back to Drupal after getting stuck on D7 and some WP fiddling, but now as I finally have to upgrade my remaining D7 site and I couldn't see any WP path I decided to git it a second try. Look good so far, but lot of new stuff to learn.

    Also feel free to propose improvements into the starterkits with merge request!

    I will, as soon as I'm more confident I know what I'm doing ;-) I saw one thing that I think needs a change but at this point I don't rely know how to make a MR
Production build 0.71.5 2024