Optionally use a key for the smtp_password instead of a config

Thanks for the MR. If we were to integrate with the Key module then it should be an option, as you suggest, and then only if Key is installed.

That said, we're already using Key (+ Encrypt) with this module without supporting it directly. See Key's documentation → regarding overriding any configuration.

There's an issue with a patch for encrypting the value: ✨ Encrypt key value Needs work

Have you tried overriding config for the password using the Key module as described in the documentation I linked to? Does this produce the desired outcome?

NW due to Key not being optional.

@imclean, what you've described in #5 sounds like we don't need to patch the phpmailer_smtp module at all?

re: #5.. yes, you could have it optional if Key is installed but this isnt the direction most other API modules (openid, s3fs, azure key vault, etc) are taking. They are simply making Key a dependency (what's the harm in that?). If you want to stick with simply storing smtp password in config, then you can add a config "key" and still do that.

+1 for the patch to add Key support.

@joseph.olstad yes this module doesn't need to be patched to make use of the Key module. Although including Key support directly can simplify the experience for the end user.

@liquidcms I checked one of the modules you mentioned and it optionally supports Key if it's installed. https://git.drupalcode.org/project/s3fs/-/blob/8.x-3.x/src/Form/Settings...