2.3.x-dev not compatible with D9

Created on 11 June 2024, 7 months ago

Problem/Motivation

After 📌 GitLab CI: Fix phpcs, eslint, and cspell tests Fixed , and the addition of a comma after every multi-line function declaration, this module is no longer compatible with the PHP version for Drupal 9.

Recent failed pipelines after commit

Steps to reproduce

Check out the tests for D9 which are now all failing with PHP syntax errors. Drupal 9 runs tests on PHP 7.4

Drupal: 9.5.11
PHP 7.4.28 (cli) (built: Jun 1 2022 23:17:36) ( NTS )

@see https://git.drupalcode.org/project/flood_control/-/jobs/1763896

Proposed resolution

- Cut a new branch version - 2.4.x? 3.0.x? for D10 (D11?) only
- Update testing targets in 2.3.x and 2.4.x/3.0.x branch to avoid running tests on releases that will not work

Remaining tasks

All of the above.

User interface changes

None.

API changes

None.

Data model changes

None.

🐛 Bug report

Status

Needs work

Version

2.3

Component

Code

Created by

🇦🇺Australia elc

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @elc
Comment 6 months ago →
🇦🇺Australia elc
Updating branch suggestions.

As this is a breaking change, the release versioning should shift to 3.0.x branch.

Using 2.4.x would suggest to people that this is a backwards compatible release, which this wouldn't be since it no longer supports D9.
Comment 6 months ago →
🇳🇱Netherlands batigolix Utrecht
Comment 3 months ago →
🇳🇱Netherlands batigolix Utrecht
I created a 3.0.x branch and a 3.0.0 release, and kept the 2.3x branch for D9.

I still need a fix for the D9 compatibility. Would be great if someone can make a MR of patch and test in with D9.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024