Add generic test coverage around Entity List Builders

Created on 10 June 2024, 7 months ago
Updated 12 June 2024, 7 months ago

Problem/Motivation

Follow up from πŸ› [regression] Menu List Builder getEntityIds() no longer calls getEntityListQuery RTBC

Steps to reproduce

N/A

Proposed resolution

TBD - Determine what needs testing and what already is tested

Remaining tasks

Update summary

User interface changes

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

πŸ“Œ Task
Status

Active

Version

11.0 πŸ”₯

Component
EntityΒ  β†’

Last updated about 16 hours ago

Created by

πŸ‡ΊπŸ‡ΈUnited States smustgrave

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

Sign in to follow issues

Comments & Activities

  • Issue created by @smustgrave
  • πŸ‡ΊπŸ‡ΈUnited States mglaman WI, USA

    Retitling. There should be generic test coverage around entity list builders implemented in Core to verify they're using the defined methods properly. Although I feel like this could be a PHPStan rule versus explicit test. "You didn't call the query method when loading entities" like the issue which spawned this.

  • πŸ‡¬πŸ‡§United Kingdom alexpott πŸ‡ͺπŸ‡ΊπŸŒ

    I'm not sure that we should do anything in core for this. The issue that spawned this problem is not something we'd write a test for and I also doubt the value of a PHPStan rule.

Production build 0.71.5 2024