Support Drush 12 and above only

Created on 6 June 2024, 5 months ago
Updated 20 August 2024, 3 months ago

Problem/Motivation

Since:
Drush versions below 12.4.3 are incompatible with Drupal 10.2.
(as per drupal 10.2.0 release notes)
module's Drush commands could perhaps be updated according to:
https://www.drush.org/12.x/commands/.

Proposed resolution

  1. Make changes in info.yml with ^10.2 || ^11
  2. Make changes as per the https://www.drush.org/12.x/commands/
  3. The file drush.services.yml could be removed and update the composer.json accordingly.
  4. Review other files that would need to be updated.
📌 Task
Status

Active

Version

3.0

Component

Code

Created by

🇮🇳India ankitv18

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @ankitv18
  • Issue was unassigned.
  • 🇳🇱Netherlands megachriz

    I think this is required to be resolved for Drupal 11 compatibility, so therefore marking it as a blocker for a stable Feeds release.

    @jcventura said on Slack he's planning to look at this issue.

  • 🇳🇱Netherlands megachriz

    I see that at least drush feeds:list still works on Drupal 11. So if all Drush commands still work as intended on Drupal 11, then this issue would no longer be a release blocker.

    It would be good to try each command manually to be sure.

  • 🇳🇱Netherlands megachriz

    I tried all commands below and they still work on Drupal 11 as intended. So this is no longer a release blocker. It is now "a nice to have" and can also be done at a later time. I'm tagging this as an intermediate issue and will add it to 🌱 [meta] Feeds intermediate issues Active .

      feeds:disable     [feeds-dis] Disable a feed specified by its id.
      feeds:enable      [feeds-en] Enable a feed specified by its id.
      feeds:import      [feeds-im] Import a feed specified by its id.
      feeds:import-all  [feeds-ima] Import all feeds.
      feeds:list-feeds  [feeds-lf] Display all feeds using a drush command.
      feeds:lock        [feeds-lk] Lock a feed specified by its id.
      feeds:unlock      [feeds-ulk] Unlock a feed specified by its id.
    
  • 🇮🇳India Rajan Kumar@2026

    To address the compatibility issues with Support Drush 12 and above only, please update your composer.json file with the following changes.

    "require-dev": {
    "drupal/pathauto": "dev-1.x",
    "drush/drush": " ^12 || ^13"
    },

  • 🇮🇳India ankitv18

    I'm using drush version 13.0.1.0 and tried to run all feeds command & it is working fine.

    Once we update the namespace as mentioned in drush 12 then we have to add conflict in the composer.json
    Also it would be great if we update the commands as per php attribute instead of document annotation.
    @megachriz what are your thoughts on this? If you consider this then we need to update the summary.

  • 🇳🇱Netherlands megachriz

    We could be using php attributes if:

    • That would work on Drupal 10.2, because that version is still officially supported;
    • That would work on PHP 8.1.

    If it works too on Drupal 10.1, that would be cool, but since 10.1 is no longer officially supported, this is less important. We should only test it once to see if we are required to raise the requirements.

Production build 0.71.5 2024