Undo/redo - user can undo the loading of the initial state

Added fix and tests on top of 📌 Add tests for undo/redo Needs review

@larowlan Does that mean you think we should not fix this bug until 📌 Add tests for undo/redo Needs review is done, i.e. to use this issue to establish the first regression test?

No not at all
We can cherry pick the fix if need be

@larowlan 👍

Oh WAIT THIS IS ALREADY ADDING A UNIT TEST! 🤩

I had missed that work already happened on the MR, and that @larowlan already wrote the test and added it to CI 😄

👏

I made the new vitest CI job run immediately, which reduces the feedback loop for work on the UI to a minimum 🥳

@jessebaker Do we want vitest from here, or Cypress unit tests from 📌 Add tests for undo/redo Needs review ?

Per #10.

jessebaker → credited hooroomoo → .

Unfortunately the added Cypress test doesn't seem to be running, there's no mention of layout slice in the CI output that I can see

Indeed. I spotted the same on Friday, and @jessebaker & @bnjmnm told me they were on it. I'm sure they'll share some news later today.

Wim Leers → closed merge request !41

@bnjmnm is working on this 👍

cypress-component-and-unit-tests-should-run branch is here to address the test setup

Aaaand now Cypress unit + functional tests are running on GitLab CI: https://git.drupalcode.org/project/experience_builder/-/jobs/1900255 — thanks to @jessebaker for reviewing + merging, but HUGE thanks to @bnjmnm for getting it to this point!

@jessebaker:

Approving because I'm keen to see this merged - but I've left a couple of comments to keep in mind when take the testing further

Could you please create one or more new issues for your remarks, to ensure we do not forget about them? 🙏

I am still seeing the issue on loading the XB.

@jessebaker: please create a new issue, otherwise this issue keeps growing in length (number of comments) and MRs (already two merged over the course of multiple weeks) and hence keeps growing in confusion.

So:

1. one new issue for #27
2. one new issue for " but I've left a couple of comments to keep in mind when take the testing further"

please create a new issue

Done:

1. https://www.drupal.org/project/experience_builder/issues/3459333 🐛 Undo/redo - user can undo the loading of the initial state (regression) Needs work
2. https://www.drupal.org/project/experience_builder/issues/3456020 📌 Document Cypress test best practices (especially how to write reliable tests) Needs review

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.