JavaScript files added by AJAX responses are only optimized in maintenance mode

The Needs Review Queue Bot → tested this issue.

While you are making the above changes, we recommend that you convert this patch to a merge request → . Merge requests are preferred over patches. Be sure to hide the old patch files as well. (Converting an issue to a merge request without other contributions to the issue will not receive credit.)

I think that is intentional but the comment may be wrong. Can you verify by reading over the original issue?

Hi

MIght be intentional but I have tested this aggregation and its not working properly and behaviour is not constant.
After analysis I have found this piece of code and I have compared with with 10.0 then looks like mistake might be I am wrong but want other also test this case before closing....

10.0

10.1 onwards

It’s understood that 🐛 ^10.1 CSS aggregation breaks during maintenance mode Fixed changed the code.

The issue seems to be that it removed a `!` from the line declaring $optimize_js, so now js is only optimized in maintenance mode. #3373328 was focused on the css aggregation, so its understandable that the missing exclamation point for js optimization would be overlooked.

Was really confused by this issue because aggregation in general is working fine, then realised this affects JavaScript added via AJAX responses only.

I'm not sure if we have an existing test for this that can be adapted. Since it's a one character fix for what was essentially a typo committed to 10.1 already, moving to needs review.

Can the issue summary be updated.

This is a small change but should tests be a follow up?

Updated the issue summary. Given this was a typo and it's a regression in released versions, I personally think tests should be a follow-up here. Would be good to add to performance test coverage but we'll need an AJAX request that adds at least two JavaScript files at once, and I'm not sure where to find one of those yet.

Thanks. Opened 📌 Add performance test coverage for AJAX requests Active for the tests.

Since this is an issue in 10.x I backported to 10.3.x

Committed and pushed 07abb808af to 11.x and b6ea46a9e1 to 11.0.x and 1bcb65983f to 10.4.x and 379efd0a0b to 10.3.x. Thanks!

nod_ → closed merge request !9204

Automatically closed - issue fixed for 2 weeks with no activity.