Resending an account email via form submission of the account form may be a bit confusing. For example, in the existing functionality for resending the welcome email, it is not clear whether any changes made in the form will be saved, or not. If the former, the button should be renamed to "Save and resend welcome message".
Moreover, this is different than the design/pattern provided by the USer module where the "Cancel account" button is a link to a separate form.
Then, separating edit permissions from resending email permissions, as proposed on ✨ Add permission for resending emails Needs review , becomes problematic.
And, finally, having a link to a separate page allows to add an entity operation that will make an operation available in listing pages.
I suggest that we have a form for resending emails, rather than adding a button on the Edit account form. If keeping a button there, it should just be a link to the form page. On this issue I'm addressing this for the account activation email as a follow up on ✨ Add action plugin for resending account activation email Needs review . A form for the welcome email email should be added on a separate issue.
- Add a form for resending the account activation email [DONE]
- To be consistent with the changes in
✨
Add permission for resending emails
Needs review
we should check whether the user resending the email has permissions to view user that the email is being sent to.
Needs review
1.0
Code
Added MR that provides the form. Builds taking into account the permission provided by ✨ Add permission for resending emails Needs review .