- Issue created by @daffie
- Merge request !8220Always default the module name setting for database driver to their driver name → (Open) created by daffie
- Status changed to Needs review
about 2 months ago 7:48am 24 September 2024 - Merge request !9592Always default the module name setting for database driver to their driver name → (Open) created by daffie
- 🇺🇸United States smustgrave
Mind rebasing? 11.x branch is 400+ commits behind.
- 🇺🇸United States smustgrave
Thanks! Test-only feature was able to run now
1) Drupal\Tests\Core\Database\UrlConversionTest::testNoModuleIsSpecifiedExceptionIsRemoved
Failed asserting that exception of type "InvalidArgumentException" matches expected exception "Drupal\Core\Extension\Exception\UnknownExtensionException". Message was: "Can not convert 'mongodb://test_user:test_pass@test_host/test_database' to a database connection, the module providing the driver 'mongodb' is not specified" at
/builds/issue/drupal-3450706/core/lib/Drupal/Core/Database/Database.php:530
/builds/issue/drupal-3450706/core/tests/Drupal/Tests/Core/Database/UrlConversionTest.php:316
.
FAILURES!Applied a nitpicky change for a void return.
Changing to the driver name didn't seem to break mysql or the other tests so believe it's a fine update.
- 🇳🇱Netherlands daffie
@quietone: You are right, it is better to use another name for the database then "mongodb". I have changed it to "dummydb". I thought that I had an option to add "mongodb" to the Drupal core code. :)
- 🇺🇸United States smustgrave
smustgrave → changed the visibility of the branch 3450706-let-for-all to hidden.
- 🇺🇸United States smustgrave
Hiding MR 8220
Feedback for 9592 has been addressed.