- Issue created by @catch
- Status changed to Needs review
7 months ago 12:54pm 29 May 2024 - 🇬🇧United Kingdom catch
The way I tested this:
1. Have 10.3.x locally.
2. composer require drupal/paragraphs drupal/entity_browser
3. Start running paragraph tests with
php ./core/scripts/run-tests.sh --sqlite 'sites/default/files/.sqlite' --directory modules/contrib/paragraphs. All we need is the run-tests.sh output about which tests are going to be run, don't actually need to run the tests, - I just crtl-C'd as soon as I had that.4. Apply the MR diff to 10.3, then run the same run-tests command, and make a note of the order (then ctrl-C again).
As with the previous issue (even though that didn't have the desired effect), it's going to be a lot easier to see any performance changes by committing it to core and then watching a contrib pipeline with concurrency, especially since we probably also need to tweak the run-tests concurrency per the linked issue on top of this.
- Status changed to RTBC
7 months ago 4:40pm 3 June 2024 - 🇺🇸United States smustgrave
smustgrave@drupal-10-3x-web:/var/www/html/web$ php ./core/scripts/run-tests.sh --sqlite 'sites/default/files/.sqlite' --directory modules/contrib/paragraphs Drupal test run --------------- Tests to be run: - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\MigrationPluginsAltererTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsStableEditPerspectivesUiTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsClaroTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsEntityReferenceWarningTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsWidgetElementsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsAddWidgetTest - Drupal\Tests\paragraphs\Functional\Migrate\MigrateUiParagraphsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDuplicateFeatureTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsHeaderActionsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDragAndDropModeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAlterByTypeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsReplicateEnableTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsLegacyContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\ParagraphsUninstallTest - Drupal\Tests\paragraphs\Functional\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionTypeSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphContentMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsFieldMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\ParagraphsBehaviorPluginsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsIsChangedTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCollapsedSummaryTest - Drupal\Tests\paragraphs\Kernel\ParagraphsEntityMethodsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsTypeHasEnabledBehaviorPluginTest - Drupal\Tests\paragraphs\Kernel\ParagraphsAccessTest - Drupal\Tests\paragraphs\Kernel\ParagraphsLangcodeChangeTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCompositeRelationshipTest - Drupal\Tests\paragraphs\Kernel\ParagraphsReplicateTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsContentModerationTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsLibraryItemEntityBrowserTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryTest - Drupal\Tests\paragraphs_library\Functional\MultilingualBehaviorTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTranslationTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTest - Drupal\Tests\paragraphs_type_permissions\Functional\ParagraphsTypePermissionsTest - Drupal\Tests\paragraphs_demo\Functional\ParagraphsDemoTestApplied MR
Tests to be run: - Drupal\Tests\paragraphs\Functional\Migrate\MigrateUiParagraphsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsAddWidgetTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsClaroTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsEntityReferenceWarningTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsStableEditPerspectivesUiTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsWidgetElementsTest - Drupal\Tests\paragraphs\Functional\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Functional\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\ParagraphsUninstallTest - Drupal\Tests\paragraphs\Functional\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsLegacyContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAlterByTypeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDragAndDropModeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDuplicateFeatureTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsHeaderActionsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsReplicateEnableTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionTypeSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphContentMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsFieldMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest - Drupal\Tests\paragraphs\Kernel\ParagraphsAccessTest - Drupal\Tests\paragraphs\Kernel\ParagraphsBehaviorPluginsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCollapsedSummaryTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCompositeRelationshipTest - Drupal\Tests\paragraphs\Kernel\ParagraphsEntityMethodsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsIsChangedTest - Drupal\Tests\paragraphs\Kernel\ParagraphsLangcodeChangeTest - Drupal\Tests\paragraphs\Kernel\ParagraphsReplicateTest - Drupal\Tests\paragraphs\Kernel\ParagraphsTypeHasEnabledBehaviorPluginTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\MigrationPluginsAltererTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTest - Drupal\Tests\paragraphs_demo\Functional\ParagraphsDemoTest - Drupal\Tests\paragraphs_type_permissions\Functional\ParagraphsTypePermissionsTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsContentModerationTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsLibraryItemEntityBrowserTest - Drupal\Tests\paragraphs_library\Functional\MultilingualBehaviorTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTranslationTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryTestAdded group #slow to a unit test
smustgrave@drupal-10-3x-web:/var/www/html/web$ php ./core/scripts/run-tests.sh --sqlite 'sites/default/files/.sqlite' --directory modules/contrib/paragraphs Drupal test run --------------- Tests to be run: - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionFieldSettingsTest - Drupal\Tests\paragraphs\Functional\Migrate\MigrateUiParagraphsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsAddWidgetTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsClaroTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsClientsideButtonsTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsEntityReferenceWarningTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsStableEditPerspectivesUiTest - Drupal\Tests\paragraphs\FunctionalJavascript\ParagraphsWidgetElementsTest - Drupal\Tests\paragraphs\Functional\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Functional\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\ParagraphsUninstallTest - Drupal\Tests\paragraphs\Functional\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsLegacyContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetLegacy\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAccessTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAddModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAdministrationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsAlterByTypeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsBehaviorsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsConfigTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContactTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsContentModerationTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDragAndDropModeTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsDuplicateFeatureTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEditModesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsEntityTranslationWithNonTranslatableParagraphs - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsFieldGroupTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsHeaderActionsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsInlineEntityFormTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsPreviewTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsReplicateEnableTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsSummaryFormatterTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationsTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTranslationTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsTypesTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsUiTest - Drupal\Tests\paragraphs\Functional\WidgetStable\ParagraphsWidgetButtonsTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\FieldCollectionTypeSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphContentMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsFieldMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest - Drupal\Tests\paragraphs\Kernel\ParagraphsAccessTest - Drupal\Tests\paragraphs\Kernel\ParagraphsBehaviorPluginsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCollapsedSummaryTest - Drupal\Tests\paragraphs\Kernel\ParagraphsCompositeRelationshipTest - Drupal\Tests\paragraphs\Kernel\ParagraphsEntityMethodsTest - Drupal\Tests\paragraphs\Kernel\ParagraphsIsChangedTest - Drupal\Tests\paragraphs\Kernel\ParagraphsLangcodeChangeTest - Drupal\Tests\paragraphs\Kernel\ParagraphsReplicateTest - Drupal\Tests\paragraphs\Kernel\ParagraphsTypeHasEnabledBehaviorPluginTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\MigrationPluginsAltererTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTest - Drupal\Tests\paragraphs_demo\Functional\ParagraphsDemoTest - Drupal\Tests\paragraphs_type_permissions\Functional\ParagraphsTypePermissionsTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsContentModerationTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsLibraryItemEntityBrowserTest - Drupal\Tests\paragraphs_library\Functional\MultilingualBehaviorTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTranslationTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryTestDoes as advertised
- 🇬🇧United Kingdom catch
#7 shows I introduced a bug here with the most recent commit. I was trying to avoid ordering alphabetically when $args['types'] was passed in, but $types_processed is set to TRUE when module is passed too, so that doesn't work. Had another look and also realised it's valid to pass multiple types to $args['types'] so I think we should just order alphabetically all the time.
Last bit of the output from #7:
- Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTest - Drupal\Tests\paragraphs_demo\Functional\ParagraphsDemoTest - Drupal\Tests\paragraphs_type_permissions\Functional\ParagraphsTypePermissionsTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsContentModerationTest - Drupal\Tests\paragraphs_library\FunctionalJavascript\ParagraphsLibraryItemEntityBrowserTest - Drupal\Tests\paragraphs_library\Functional\MultilingualBehaviorTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryItemTranslationTest - Drupal\Tests\paragraphs_library\Functional\ParagraphsLibraryTestLast bit of the output after reverting that last change;
- Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\MigrationPluginsAltererTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTestLeaving RTBC since it's just removing an if statement that regressed from the previous state of the patch.
- Status changed to Needs work
7 months ago 3:58am 5 June 2024 - 🇳🇿New Zealand quietone
I read the issue summary, comments and the MR. This look very straightforward. I then did the manual testing as described in #6 and used the same Unit test as smustgrave in #7. I reproduced the same results as #7 not #8. I don't think the revert stated in #8 was pushed.
- Status changed to Needs review
7 months ago 8:36am 5 June 2024 - Status changed to Needs work
7 months ago 11:14am 5 June 2024 - 🇳🇿New Zealand quietone
@catch, thanks.
I now get the expected order of tests. However, I also get a deprecation
$php ./core/scripts/run-tests.sh --sqlite 'sites/default/files/.sqlite' --directory modules/contrib/paragraphs PHP Deprecated: usort(): Returning bool from comparison function is deprecated, return an integer less than, equal to, or greater than zero in /var/www/html/core/scripts/run-tests.sh on line 939 PHP Stack trace: PHP 1. {main}() /var/www/html/core/scripts/run-tests.sh:0 PHP 2. simpletest_script_get_test_list() /var/www/html/core/scripts/run-tests.sh:168This is on 10.3.x and PHP 8.3.
- Status changed to Needs review
7 months ago 10:13pm 5 June 2024 - 🇬🇧United Kingdom catch
Thanks need to check my ddev is reporting deprecation errors properly. Added a cast before returning.
- Status changed to Needs work
7 months ago 2:43am 6 June 2024 - 🇳🇿New Zealand quietone
No deprecations but the sorting still wasn't as expected. I re-read the PHP man page for usort and spotted a problem with the return values from the callback. I left a suggestion in the MR about that.
- Status changed to Needs review
7 months ago 6:17am 6 June 2024 - Status changed to RTBC
7 months ago 6:38am 6 June 2024 - 🇳🇿New Zealand quietone
I retested on 10.3.x and the end of the list is now sorted by test type. The end of the list is now as expected.
- Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemRevisionSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsItemSourceTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeMigrationTest - Drupal\Tests\paragraphs\Kernel\migrate\ParagraphsTypeSourceTest - Drupal\Tests\paragraphs\Unit\migrate\FieldCollectionsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\MigrationPluginsAltererTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldInstanceSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsFieldSettingsTest - Drupal\Tests\paragraphs\Unit\migrate\ParagraphsProcessOnValueTestSo, this is now good to go.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
Committed and pushed af8831671c to 11.x and bef045d92f to 11.0.x and 9699eff69f to 10.4.x and a47b41772e to 10.3.x. Thanks!
Backported to 10.3.x as a test only change
-
alexpott →
committed a47b4177 on 10.3.x
Issue #3450616 by catch, quietone, smustgrave: Optimize test order when...
-
alexpott →
committed a47b4177 on 10.3.x
-
alexpott →
committed 9699eff6 on 10.4.x
Issue #3450616 by catch, quietone, smustgrave: Optimize test order when...
-
alexpott →
committed 9699eff6 on 10.4.x
-
alexpott →
committed bef045d9 on 11.0.x
Issue #3450616 by catch, quietone, smustgrave: Optimize test order when...
-
alexpott →
committed bef045d9 on 11.0.x
- Status changed to Fixed
6 months ago 12:26pm 11 June 2024 -
alexpott →
committed af883167 on 11.x
Issue #3450616 by catch, quietone, smustgrave: Optimize test order when...
-
alexpott →
committed af883167 on 11.x
Automatically closed - issue fixed for 2 weeks with no activity.