[1.0.x] Event Log Track Encrypt

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml event_log_track_encrypt/

FILE: event_log_track_encrypt/README.md
-------------------------------------------------------------------------
FOUND 1 ERROR AND 34 WARNINGS AFFECTING 35 LINES
-------------------------------------------------------------------------
   7 | WARNING | [ ] Line exceeds 80 characters; contains 180 characters
  35 | WARNING | [ ] Line exceeds 80 characters; contains 107 characters
  36 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
  42 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
  45 | WARNING | [ ] Line exceeds 80 characters; contains 138 characters
  48 | WARNING | [ ] Line exceeds 80 characters; contains 98 characters
  49 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  50 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
  57 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
  58 | WARNING | [ ] Line exceeds 80 characters; contains 87 characters
  59 | WARNING | [ ] Line exceeds 80 characters; contains 111 characters
  60 | WARNING | [ ] Line exceeds 80 characters; contains 112 characters
  63 | WARNING | [ ] Line exceeds 80 characters; contains 148 characters
  71 | WARNING | [ ] Line exceeds 80 characters; contains 84 characters
  75 | WARNING | [ ] Line exceeds 80 characters; contains 270 characters
  78 | WARNING | [ ] Line exceeds 80 characters; contains 167 characters
  80 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
  82 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
  92 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 104 | WARNING | [ ] Line exceeds 80 characters; contains 155 characters
 105 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 106 | WARNING | [ ] Line exceeds 80 characters; contains 165 characters
 108 | WARNING | [ ] Line exceeds 80 characters; contains 152 characters
 110 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
 136 | WARNING | [ ] Line exceeds 80 characters; contains 146 characters
 137 | WARNING | [ ] Line exceeds 80 characters; contains 670 characters
 138 | WARNING | [ ] Line exceeds 80 characters; contains 170 characters
 139 | WARNING | [ ] Line exceeds 80 characters; contains 169 characters
 151 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
 152 | WARNING | [ ] Line exceeds 80 characters; contains 652 characters
 156 | WARNING | [ ] Line exceeds 80 characters; contains 114 characters
 164 | WARNING | [ ] Line exceeds 80 characters; contains 777 characters
 165 | WARNING | [ ] Line exceeds 80 characters; contains 776 characters
 166 | WARNING | [ ] Line exceeds 80 characters; contains 653 characters
 167 | ERROR   | [x] Expected 1 newline at end of file; 4 found
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: event_log_track_encrypt/config/install/event_log_track.encrypt.settings.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 15 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: event_log_track_encrypt/config/schema/event_log_track_encrypt.schema.yml
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 49 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: event_log_track_encrypt/src/Commands/EventLogTrackDecryptCommands.php
--------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------
 353 | ERROR | The array declaration extends to column 100 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------

2. FILE: event_log_track_encrypt.module

/**
 * @file
 * Integrates encrypt.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

3. FILE: src/Commands/EventLogTrackDecryptCommands.php

  /**
   * EventLogTrackDecryptCommands constructor.
   *
   * @param \Drupal\Core\Database\Connection $connection
   *   The database connection service.
   * @param \Drupal\Core\Extension\ModuleHandlerInterface $moduleHandler
   *   The module_handler service.
   */
  public function __construct(Connection $connection, ModuleHandlerInterface $moduleHandler) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

Hi Vishal,

Thank you for your quick feedback.

1. Fix phpcs issues.

All errors detected by phpsc are fixed.

2. FILE: event_log_track_encrypt.module

Description for a .module file is updated.

3. FILE: src/Commands/EventLogTrackDecryptCommands.php

Documentation comment for constructors is updated.

Please review.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Hi Vishal,

Many thanks for your help.

Thank you for your contribution!
I updated your account so you can now opt into security advisory coverage for any project you created and every project you will create.

These are some recommended readings to help you with maintainership:

• Dries → ' post on Responsible maintainers
• Maintainership →
• Git version control system →
• Issue procedures and etiquette →
• Maintaining and responding to issues for a project →
• Release naming conventions → .

You can find more contributors chatting on Slack → or IRC → in #drupal-contribute. So, come hang out and stay involved → !

Thank you for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review → . I encourage you to learn more about that process and join the group of reviewers.

I thank also the dedicated reviewers as well.

Automatically closed - issue fixed for 2 weeks with no activity.