- Issue created by @larowlan
- First commit to issue fork.
- Assigned to hooroomoo
- π¬π§United Kingdom jessebaker
As mentioned in the description, this is hopefully fairly easy to implement through Redux. I met with hooroomoo β and we discussed that both the layout and model slices of the redux state will need to be added to the undo "array" so that changes to both the layout and the props/details of a component will be tracked as undo-able states.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Great to see this moving! π€©
I suspect end-to-end tests using Cypress is overkill for this. (Happy to be wrong.) Unit tests seem appropriate for such a foundational capability?
- πΊπΈUnited States hooroomoo
Will continue off 3450303-undo-redo now that sidepanels branch is merged
- πΊπΈUnited States hooroomoo
hooroomoo β changed the visibility of the branch sidepanels-undo to hidden.
- πΊπΈUnited States hooroomoo
Created π Add tests for undo/redo Needs review to write tests. Would like to get this in first since it has a good amount of refactoring.
- Status changed to Needs review
6 months ago 8:37pm 5 June 2024 - Assigned to jessebaker
- Status changed to RTBC
6 months ago 8:59am 6 June 2024 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Both @larowlan and @jessebaker have approved the MR.
I think that means this is RTBC?
But shouldn't we have (unit) tests prior to merging?
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Ah, @jessebaker pointed out that for tests, we have the follow-up π Add tests for undo/redo Needs review , which is blocked on another issue. Great!
- Assigned to bnjmnm
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
Needs Ben's MR approval before it can be merged π
- Issue was unassigned.
- Status changed to Fixed
6 months ago 6:09pm 6 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.