[10.x-4.x] Desk-Net

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

• The following points are just a start and don't necessarily encompass all of the changes that may be necessary
• A specific point may just be an example and may apply in other places
• A review is about code that doesn't follow the coding standards, contains possible security issue, or does not correctly use the Drupal API; the single points are not ordered, not even by importance

src/Controller/ModuleSettings.php

That class is not a controller; it is rather a helper class with static methods, which should be changed to a service class. It must also be moved from that directory, and use a different parent class.

src/Controller/ActionController.php

The properties already defined from the parent class do not need to be redefined. The parent class has methods to set those property, which should be used instead of accessing directly those properties.
This class is not used to define any route.

src/Controller/APIController.php

Controllers are not defined in the services.yml file. Services can be used as controllers but, in that case, the parent class cannot be ControllerBase.
The consequence of this is that controllers cannot be created calling $container->get().
A controller does not have another controller as property; if there is code that is common to more controllers, that should be moved to a service.

src/Controller/RequestsController.php

This class is not used to define any route.

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml desk_net/

FILE: desk_net/desk_net.module
-----------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------
   1 | ERROR   | [x] Missing file doc comment
  11 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Entity\EntityInterface.
  35 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  39 | ERROR   | [x] Object operator not indented correctly; expected 4 spaces but found 6
  54 | ERROR   | [x] list(...) is forbidden, use [...] instead.
  59 | WARNING | [ ] Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for
     |         |     xyz-bar.html.twig.", "* Implements hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
  98 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 111 | ERROR   | [x] Data types in @param tags need to be fully namespaced
 237 | ERROR   | [x] Expected 1 newline at end of file; 2 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/desk_net.info.yml
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-----------------------------------------------------------------------
  1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
  9 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
 10 | WARNING | All dependencies must be prefixed with the project name, for example "drupal:"
-----------------------------------------------------------------------


FILE: desk_net/desk_net.install
-----------------------------------------------------------------------
FOUND 2 ERRORS AND 7 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------
  9 | WARNING | [x] Unused use statement
  9 | ERROR   | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Core\Database\Connection.
 10 | WARNING | [x] Unused use statement
 11 | WARNING | [x] Unused use statement
 14 | WARNING | [x] Unused use statement
 15 | WARNING | [x] Unused use statement
 16 | WARNING | [x] Unused use statement
 41 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 69 | ERROR   | [x] Object operator not indented correctly; expected 4 spaces but found 6
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/config/install/desk_net.settings.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 24 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/config/schema/desk_net.schema.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 76 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/src/Controller/ActionController.php
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
-----------------------------------------------------------------------
 1335 | WARNING | Line exceeds 80 characters; contains 92 characters
 1417 | WARNING | Line exceeds 80 characters; contains 95 characters
 1419 | WARNING | Line exceeds 80 characters; contains 103 characters
 1426 | WARNING | Line exceeds 80 characters; contains 99 characters
 1448 | WARNING | Line exceeds 80 characters; contains 99 characters
 1450 | WARNING | Line exceeds 80 characters; contains 107 characters
 1457 | WARNING | Line exceeds 80 characters; contains 99 characters
 1463 | WARNING | Line exceeds 80 characters; contains 83 characters
-----------------------------------------------------------------------


FILE: desk_net/desk_net.permissions.yml
-----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------
 3 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------


FILE: desk_net/desk_net.links.task.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 53 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

2. FILE: desk_net.module

/**
 * Implements HOOK_form_BASE_FORM_ID_alter.
 */
function desk_net_form_node_form_alter(&$form, FormStateInterface $form_state) {

The description for that hook should also say for which form that hook is implemented, either by indicating that with the name of the class that implements the form (namespace included) or the form ID.