- Issue created by @lawxen
- last update
11 months ago 41 pass - Status changed to Needs review
11 months ago 5:31am 27 May 2024 - š©šŖGermany christianadamski Berlin, Germany
Fair enough, started merging.
Also: I was in Shanghai several months last year/early this year and found no Drupal events happening at all. Would have loved to visit you guys :)
Which map provider are you using in you project?
- šØš³China lawxen
Thanks @ChristianAdamski, We are using Baidu Map.
I'm in Shanghai, too, there have been fewer events recently, mainly because several of the people who previously hosted the event have been busy with other things. When you come shanghai again, Let's get some of the drupal guys out for a beer šŗ.
- š©šŖGermany christianadamski Berlin, Germany
1.) Currently issues with some newly added Google Maps based tests. They work/not randomly.
2.) Without having looked at the code, I think there are several spots where ModuleHandler is used instead of the Interface.
3.) My wife lived 6 years in Shanghai until March. We will come to Shanghai next year anyway, so will pick you up on your offer :)
4.) If you need any support, reach out. Would love to work in connection with Shanghai, my wife misses it quite a bit :) - Status changed to Needs work
11 months ago 6:28am 27 May 2024 - šØš³China lawxen
Yes, There'are many other placed need be changed to ModuleHandlerInterface, Let me submit it now.
3)
4)
āļø - Merge request !54Move ModuleHandler to ModuleHandlerInterface In __Construct to capable with hook_event_dispatcher ā (Merged) created by lawxen
- last update
11 months ago 41 pass - Status changed to Needs review
11 months ago 6:53am 27 May 2024 - šØš³China lawxen
https://git.drupalcode.org/project/geolocation/-/merge_requests/53 didn't fully handle the problem.
I have created another MR : https://git.drupalcode.org/project/geolocation/-/merge_requests/54 and have tested on views, no error come again with hook_event_dispatcher. - Status changed to Fixed
11 months ago 7:33am 27 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.