[2.0.0-alpha3] Feedbacks about Views module

Created on 26 May 2024, about 1 month ago
Updated 25 June 2024, 6 days ago

What was not done in πŸ› [2.0.0-alpha2] Feedbacks about Views module Fixed

View style

View rows: empty renderable even when results Status : fix

❌ I still see the issue:

  1. I create a view of articles. I have at least one published article in my site.
  2. I chose "Component (UI Patterns)" as view style & "content: teaser" as view rows
  3. I chose Bootstrap 5's Alert components and I put "View rows" source in the message slot
  4. I save the view
  5. FAIL: I don't see the rows in front

But, if I add another source in the same slot of an other slot, it appears ! So it may be a cache issue.

Let's talk about that in Alpha3.

TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): error should appear only when you choose ui patterns views plugins inside views (the first time when choose on the radios button "Component (UI patterns)", this error seems to be related to views, for example with better exposed filter I'v got the same issue (enable BEF, expose pager, select the BEF plugin, the select of pager ajax not working at the first popup ) I try to debug but it's very complicated, I think I will try to resolve this at the end of develop. I also started an issue on Core https://www.drupal.org/project/drupal/issues/3447838 πŸ› Ajax callback inside views plugin doesn't work. Active

Let's follow this in alpha3.

View row

The view fields are not available as sources for slots. Status : fix

❌ I have this issue:

Call to undefined method Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource::getSettings() in Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource

Architecture

Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

Let's talk about that in Alpha3.

πŸ› Bug report
Status

Closed: cannot reproduce

Version

2.0

Component

UI Patterns Views

Created by

πŸ‡«πŸ‡·France pdureau Paris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @pdureau
  • πŸ‡«πŸ‡·France pdureau Paris

    Also:

      ------ ---------------------------------------------------------------------------------------- 
      Line   ui_patterns/modules/ui_patterns_views/src/Plugin/UiPatterns/Source/ViewFieldSource.php  
     ------ ---------------------------------------------------------------------------------------- 
      108    Call to an undefined method                                                             
             Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource::getSettings().       
     ------ ----------------------------------------------------------------------------------------
  • πŸ‡«πŸ‡·France pdureau Paris

    TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): Argument #1 ($component_id) must be of type string, null given, called in src/Element/ComponentElementBuilder.php on line 40 in Drupal\Core\Theme\ComponentPluginManager->find() (line 133 of /core/lib/Drupal/Core/Theme/ComponentPluginManager.php).

    Was also find in ui_patterns_blocks, so may not be specific to ui_patterns_views.

  • πŸ‡«πŸ‡·France pdureau Paris

    About the cache issue, have a look on SourceInterface::alterComponent()

  • πŸ‡«πŸ‡·France Musa.thomas France πŸ‡«πŸ‡·

    Musa.thomas β†’ made their first commit to this issue’s fork.

  • Assigned to Musa.thomas
  • πŸ‡«πŸ‡·France Musa.thomas France πŸ‡«πŸ‡·
  • πŸ‡«πŸ‡·France pdureau Paris

    Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

    Moved to its own beta1 ticket: πŸ“Œ [2.0.0-beta1] Do we take care of the big object in views config? Active

  • πŸ‡«πŸ‡·France Musa.thomas France πŸ‡«πŸ‡·

    Musa.thomas β†’ changed the visibility of the branch 2.0.x to hidden.

  • πŸ‡«πŸ‡·France Musa.thomas France πŸ‡«πŸ‡·

    Didn't reproduce the problem of cache

  • Status changed to Closed: cannot reproduce 6 days ago
  • πŸ‡«πŸ‡·France Musa.thomas France πŸ‡«πŸ‡·
Production build 0.69.0 2024