[2.0.0-alpha2] Feedbacks about Views module

Musa.thomas → made their first commit to this issue’s fork.

1. For this error :
   

   TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): Argument #1 ($component_id) must be of type string, null given, called in src/Element/ComponentElementBuilder.php
   

   , should appear only when you choose ui patterns views plugins inside views (the first time when choose on the radios button "Component (UI patterns)", this error seems to be related to views, for example with better exposed filter I'v got the same issue (enable BEF, expose pager, select the BEF plugin, the select of pager ajax not working at the first popup ) I try to debug but it's very complicated, I think I will try to resolve this at the end of develop. I also started an issue on Core https://www.drupal.org/project/drupal/issues/3447838 🐛 Ajax callback inside views plugin doesn't work. Active Status : wip

Issues with props:
View title: i get the component name instead of the view titile : Status : didn't reproduce
2. View title: also InvalidComponentDataException but that's normal because it is not a source for slots. : Status fix (I don't understand why title is not source of slots?)
3. View rows: empty renderable even when results Status : fix
4. Wysiwyg: InvalidComponentDataException[...] Status : didn't reproduce (where do you choose the plain text format ?)
5. The view fields are not available as sources for slots. Status : fix
6. Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

View style

View title: i get the component name instead of the view titile : Status : didn't reproduce

Fixed ✅

View title: also InvalidComponentDataException but that's normal because it is not a source for slots. : Status fix (I don't understand why title is not source of slots?)

Fixed ✅

Title is not a source of slot because it is a string scalar. However, it will be possible to inject it to slots thanks to 📌 [2.0.0-alpha3] Implement PropTypeInterface::convertFrom() Needs review

If we add manually slot here, we will need to add it to all sources for string props

View rows: empty renderable even when results Status : fix

❌ I still see the issue:

1. I create a view of articles. I have at least one published article in my site.
2. I chose "Component (UI Patterns)" as view style & "content: teaser" as view rows
3. I chose Bootstrap 5's Alert components and I put "View rows" source in the message slot
4. I save the view
5. FAIL: I don't see the rows in front

But, if I add another source in the same slot of an other slot, it appears ! So it may be a cache issue.

Let's talk about that in Alpha3.

Wysiwyg: InvalidComponentDataException[...] Status : didn't reproduce (where do you choose the plain text format ?)

Fixed ✅

TypeError: Drupal\Core\Theme\ComponentPluginManager::find(): error should appear only when you choose ui patterns views plugins inside views (the first time when choose on the radios button "Component (UI patterns)", this error seems to be related to views, for example with better exposed filter I'v got the same issue (enable BEF, expose pager, select the BEF plugin, the select of pager ajax not working at the first popup ) I try to debug but it's very complicated, I think I will try to resolve this at the end of develop. I also started an issue on Core https://www.drupal.org/project/drupal/issues/3447838 🐛 Ajax callback inside views plugin doesn't work. Active

Let's follow this in alpha3.

View row

The view fields are not available as sources for slots. Status : fix

❌ I have this issue:

Call to undefined method Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource::getSettings() in Drupal\ui_patterns_views\Plugin\UiPatterns\Source\ViewFieldSource

Architecture

Architecture Status : fix BUT, we add lot of (big) object inside the configuration mapping, hope will not causing any performance issue but should not be. Also now when something is empty et should not be render it return something empty, before it was unset of mapping=> maybe in this case some extra empty tag should not be render

Let's talk about that in Alpha3.

Remaining subjects moved to 🐛 [2.0.0-alpha3] Feedbacks about Views module Active

Lets merge once the MR is created (I do the merge, because i have a few commits to add)

Automatically closed - issue fixed for 2 weeks with no activity.