- Issue created by @Ammar_Arman
- Status changed to Needs review
6 months ago 3:18pm 26 May 2024 - 🇨🇦Canada mandclu
This module is intended for back end use, but the fact that the module's functionality unintentionally also becomes available on a couple of publicly available form doesn't strike me as requiring a permission to be set. In particular, requiring a permission to be set means that additional configuration is required before this module cab be used by all content editors.
I'd be more inclined to add a configuration setting that allows site builders to configure forms they want to exclude. If we were going that route, we could also add a field to configure forms they specifically want included.
- 🇨🇦Canada mandclu
I've created ✨ Allow configuration of forms to include and exclude Fixed to capture what I would prefer as the solution.
- 🇯🇴Jordan Rajab Natshah Jordan
Noted;
Thanks, Martin, for the quick look.
I agree with you that "additional configuration is required before this module can be used."I was about to flip the logic with `not use keysave` at some point today while I was reviewing. The idea of use keysave was borrowed from the Hotkeys for Save module.
I only wanted to let anonymous users use the Ctrl+S key to download the HTML, not to send post submissions in forms and try to send data, such as in a "Contact Us" form or filters.
For example, on a page with filters and a submit button, when I click Ctrl+S five times or keep pressing it, the page will now download, but the page will keep posting submissions to the server to query.
A Webform with no validation or next steps, will keep submitting.
Thanks, for the quick review, we may invest time on ✨ Allow configuration of forms to include and exclude Fixed before shipping the use of this mode in our product.
- 🇨🇦Canada mandclu
Sounds great! I've posted an MR there, so you could start with a review of that.
- Status changed to Closed: won't fix
6 months ago 11:30pm 26 May 2024 - 🇯🇴Jordan Rajab Natshah Jordan
Got that, that was quick.
Having a testing round for sure, and a switch of logic.
Closing this issue as won't fix. - 🇨🇦Canada mandclu
Thanks! I actually merged the changes there, and some additional fixes, to the dev branch. Planning to roll a new release shortly, but if you have time to review or test the dev branch first, I would value your feedback.
- 🇯🇴Jordan Rajab Natshah Jordan
Yeh, Noticed that.
I had a look at your commit.
Dropping the logic of
Moving to have a default set of included and exloaded forms after
✨ Allow configuration of forms to include and exclude Fixed