Cache Tags invalidation support

Thank you so much for your contribution

Marking as needs review

eduardo morales alberti → made their first commit to this issue’s fork.

We created the fork to make some changes, but after reviewing and testing the patch, we validated it and is not needed.
Reviewed and tested.

Nice! Thanks for your feedback

I'll try to focus on this

We got some errors from the cache tags on some pages:

TypeError: array_merge(): Argument #1 must be of type array, null given in array_merge() (line 140 of /var/www/html/docroot/modules/contrib/modal_page/modal_page.module).

LogicException: A stray renderRoot() invocation is causing bubbling of attached assets to break. in Drupal\Core\Render\Renderer->renderRoot() (line 156 of /var/www/html/docroot/core/lib/Drupal/Core...

Warning: Undefined array key "tags" in modal_page_preprocess_html() (line 141 of /var/www/html/docroot/modules/contrib/modal_page/modal_page.module) #0 /var/www/html/docroot/core/includes/bootstrap...

Hey Eduardo, thanks for your effort helping Modal project

About your update on MR, seems that we can reduce one condition here:

if (isset($variables['page'])) {
  if (!isset($variables['page']['#cache']['tags'])) {
    $variables['page']['#cache']['tags'] = [];
  }

To this, right?

if (isset($variables['page']) && !isset($variables['page']['#cache']['tags'])) {
  $variables['page']['#cache']['tags'] = [];
}

Nevermid, I saw that the rest of logic and really makes sense this logic

Thank you for reviewing @renatog. Are there any pending issues?

Thank you for reviewing @renatog

My pleasure! Appreciated your effort on this @eduardo-morales-alberti

Are there any pending issues?

Not from my side. It's ready to be reviewed?

On #7 you marked as "Needs work"
On #8 you updated the MR but the status wasn't updated to "Needs Review" so I assumed that was pending something else
If everything is ok, please update to NR and we can test that and move forward

Sorry, my bad.
Ready to review, working properly for our side.

After using code from MR I open "/admin/structure/modal/add" and there is a unexpected error

Error: Call to undefined method Drupal\Core\Render\Renderer::renderInIsolation() in Drupal\modal_page\Form\ModalForm->form() (line 118 of /app/web/modules/contrib/modal_page/src/Form/ModalForm.php).

Rolling back to NR, because seems not related to this MR

Issue above is fixed at 🐛 Render plain image is deprecated Needs work

Tested and it's really working fine

Moved to the dev branch

Thanks everyone

Automatically closed - issue fixed for 2 weeks with no activity.