- Issue created by @eduardo morales alberti
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
Replaced renderPlain with renderInIsolation, remove 9.3 from .info module as Drupal 9 is not supported by Drupal and renderInIsolation is not compatible with drupal 9.
If we want to maintain drupal 9, then we should check if renderInIsolation exists, but supporting drupal 9 and 11 is not recommended. - 🇧🇷Brazil renatog Campinas
If we want to maintain drupal 9, then we should check if renderInIsolation exists, but supporting drupal 9 and 11 is not recommended
Agreed
Tested and works well
- 7bd1838d committed on 5.0.x
Issue #3483358 by eduardo morales alberti, renatog: Render plain image...
- 7bd1838d committed on 5.0.x
- 🇧🇷Brazil renatog Campinas
Moved to the dev branch
Thanks for the nice catch
- 🇧🇷Brazil renatog Campinas
After using code from MR I open "/admin/structure/modal/add" and there is a unexpected error
Error: Call to undefined method Drupal\Core\Render\Renderer::renderInIsolation() in Drupal\modal_page\Form\ModalForm->form() (line 118 of /app/web/modules/contrib/modal_page/src/Form/ModalForm.php).
Drupal 10.2.7
- d2a27c7c committed on 5.0.x
Issue #3483358 by eduardo morales alberti, renatog: Render plain image...
- d2a27c7c committed on 5.0.x
- 7eeeda5d committed on 6.0.x
Issue #3483358 by eduardo morales alberti, renatog: Render plain image...
- 7eeeda5d committed on 6.0.x
- 🇧🇷Brazil renatog Campinas
Moved the same fix of 🐛 Problem with version 2.0.3 and drupal 10 Active
- 🇪🇸Spain eduardo morales alberti Spain, 🇪🇺
@renatog, sorry because renderInIsolation comes from Drupal 10.3 https://www.drupal.org/node/3407994 →
Maybe we should add ^10.3 on the .info and composer.json as the 10.2.x is not supported.But the check that you introduced is also valid.
- 🇧🇷Brazil renatog Campinas
Maybe we should add ^10.3 on the .info and composer.json as the 10.2.x is not supported
But the check that you introduced is also valid
Yes, the check is like a fallback just to avoid break someone, but agreed that the info update, would be nice
If you can report an issue, will be really appreciated. If not I can do this later
I also added a Matrix in the project page to help with the supported version
Automatically closed - issue fixed for 2 weeks with no activity.