- Issue created by @baldwinlouie
- Merge request !2295Add option to specify default cloud store uid. β (Merged) created by baldwinlouie
- last update
7 months ago 7 pass, 125 fail - Status changed to Needs review
7 months ago 12:07am 24 May 2024 - πΊπΈUnited States baldwinlouie
@yas, Please review this patch. This adds a new field to the K8s cloud service provider form.
When cloud store entities are imported, they will use the uid from the cloud service provider entity.
- Status changed to Needs work
7 months ago 1:38am 24 May 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for the patch. I posted my comments. Basically, I am requesting you to change the name from store to cloud_store. Also, can you avoid the hard-coding for the anonymous user ID `0`? I don't have any idea to implement it, though.
Thanks!
- πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Also, can you please check the PHPUnit test failure?
β https://git.drupalcode.org/project/cloud/-/jobs/1672862#L857
Thanks
- last update
7 months ago 7 pass, 125 fail - Status changed to Needs review
7 months ago 6:24pm 24 May 2024 - πΊπΈUnited States baldwinlouie
@yas, please review this patch again. I've incorporated all your feedback. I also fixed the Unit Test: https://git.drupalcode.org/project/cloud/-/jobs/1681933
- Status changed to RTBC
7 months ago 10:20pm 24 May 2024 - πΊπΈUnited States yas California πΊπΈ
@baldwinlouie
Thank you for the refactoring. I ran the BDD tests and it looks good to me now. Iβll merge the patch to
6.x
and7.x
; and close this issue as Fixed. - last update
7 months ago 7 pass, 125 fail -
yas β
committed eb9fcfb1 on 7.x authored by
baldwinlouie β
Issue #3449171 by baldwinlouie, yas: Add a default user to K8s cloud...
-
yas β
committed eb9fcfb1 on 7.x authored by
baldwinlouie β
- Status changed to Fixed
7 months ago 10:21pm 24 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.