Fetch FA library locally before CDN

I've created a Merge request for this issue, please review.

+1

I merged dev into the issue fork branch.

I removed this part from composer.json, since it's already specified in the info file:

-    "require": {
-        "drupal/core": "^8 || ^9 || ^10"
-    }

Patch for 2.9, including latest dev code.

Generally I like the approach, one question/concern though -- do we need to display a warning urging people to add the font awesome library manually? If the only way to remove the warning is by getting the library manually, why not just require the library?

I'm not really sure, was just blindly rerolling a patch I was using.

I think the way it **should** work is using the CDN by default without issue, and **allowing** you to to use a local version.

@japerry It's just best practice when hosting your website to get the libraries locally. This is so that your libraries don't suddenly get updated when its not required and also so that in case a CDN is a little slow to reach your end users wont notice it, because its just loaded through your webserver.

As for the warning, its something I see basically all modules do, so its something I also implemented. We can implement something so the warning is suppressible, but I don't think it's worth it, as people can choose to ignore it anyway.

mortona2k → changed the visibility of the branch 3449108-fetch-fa-library to hidden.

Without using this patch, and no libraries/font-awesome, it looks like fontawesome icons are available, but I can't see them in the UI.

If I install the fontawesome module, the icons appear.

The patch doesn't change the library being used, it's still loaded by fontawesome.

With the patch and libraries/font-awesome, and no fontawesome module, no icons appear.

I don't think the CDN is working at all? Seems like it depends on fontawesome to load the library.