[1.0.x] Image Scale and Fill Background Effect

Thank you for applying!

Please read Review process for security advisory coverage: What to expect → for more details and Security advisory coverage application checklist → to understand what reviewers look for. Tips for ensuring a smooth review → gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications → , Application workflow → , What to cover in an application review → , and Tools to use for reviews → .

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool → only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues → .

Thanks for taking this up, I have done phpcs --standard=Drupal,DrupalPractice and fixed all the issues. Let me know if there are anything I need to take care of on this.

Fix phpcs issue

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml image_scale_fill/

FILE: image_scale_fill/README.md
------------------------------------------------------------------------
FOUND 1 ERROR AND 13 WARNINGS AFFECTING 13 LINES
------------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 420 characters
7 | WARNING | [ ] Line exceeds 80 characters; contains 89 characters
12 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
18 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
19 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters
20 | WARNING | [ ] Line exceeds 80 characters; contains 137 characters
21 | WARNING | [ ] Line exceeds 80 characters; contains 161 characters
22 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
26 | WARNING | [ ] Line exceeds 80 characters; contains 88 characters
28 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
37 | WARNING | [ ] Line exceeds 80 characters; contains 138 characters
41 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
51 | WARNING | [ ] Line exceeds 80 characters; contains 94 characters
51 | ERROR | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------

FILE: image_scale_fill/src/Plugin/ImageEffect/ScaleFillBackgroundEffect.php
-------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------
59 | WARNING | Line exceeds 80 characters; contains 81 characters
142 | WARNING | Line exceeds 80 characters; contains 95 characters
310 | WARNING | Line exceeds 80 characters; contains 88 characters
-------------------------------------------------------------------------------------------

FILE: image_scale_fill/image_scale_fill.info.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
7 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Time: 90ms; Memory: 14MB

I am changing priority as per Issue priorities → .

This thread has been idle, in the Needs work state with no activity for several months. Therefore, I am assuming that you are no longer pursuing this application, and I marked it as Closed (won't fix).

If this is incorrect, and you are still pursuing this application, then please feel free to re-open it and set the issue status to Needs work or Needs review, depending on the current status of your code.