InstallerTranslationExistingFileTest fails on 11.x branch

I’m not sure where it should be fixed, (more specifically I’m not sure what translation file name format we WANT to use for 11.0-dev, but once we know, we need to adjust either of those two regexes above to download and/or find the right file)

Here's the simplest fix I see for this test, making the patch value optional in the regex that filetranslation uses to detect files.

Also, I was trying to figure out why the version change was committed 9 days ago, and we are just seeing this test fail now. The drupal-11.0-dev.xx-lolspeak.po file that is downloaded has metadata indicating it's the file for 11.0.0-beta1. I suspect that file was added to the server with the beta release late last week. The test only tests that a 200 status is returned after selecting a language. If the download fails, the installer displays a requirements page stating that the file is missing rather than trying to reload the page, so the test passes if the download fails. So it wouldn't have been a problem until the download succeeded, but the installer couldn't detect the downloaded file.

I'm wondering if we should do something more robust here, like add a query parameter on the redirect indicating that we downloaded the translation file, so when we go back through we see that we thought we downloaded it, but can't find it and report the error instead of an endless redirect. Or a more structured way of ensuring that whatever is set as the drupal version will pass the FileTranslation scanner. I'm really not sure, It's been a while since I got deep in the installer code, and I'm not that familiar with the deep parts of the string translation system and po files to know what else could be screwed up by changing the FileTranslation scanner. I suspect the change here is probably safe, but still don't know if it's the right thing to do.

Moving to critical per https://www.drupal.org/docs/develop/issues/fields-and-other-parts-of-an-... →

Cause tests to fail in HEAD on the automated testing platform for any supported environment (including random failures), since this blocks all other work.

I think we should open a follow-up for #6 to make things more robust, but also let's go ahead here to un-break HEAD again. All of this will change again once we can use a main branch instead of 11.x.

larowlan → closed merge request !8120

Thanks, committed to 11.x

Tagging per #8

Automatically closed - issue fixed for 2 weeks with no activity.

Opened 📌 Harden installer translation file download against potential infinite redirects Active as a follow-up