- Issue created by @robertragas
- Merge request !19Issue #3447595 : When the user has seen the pop-up and the prompt has been... → (Merged) created by robertragas
- Status changed to Needs review
8 months ago 12:07pm 16 May 2024 - Status changed to RTBC
8 months ago 12:21pm 16 May 2024 -
robertragas →
committed 06145c8b on 2.0.x
Issue #3447595 : When the user has seen the pop-up and the prompt has...
-
robertragas →
committed 06145c8b on 2.0.x
- 🇳🇱Netherlands kingdutch
This was caused by changes made in 🐛 Re-installing the app invalidates the subscription but not the pop-up Fixed which incorrectly interpreted the purpose of
pushNotificationPromptTime
. Before that issue the code insocial_pwa.module
would not attach the JavaScript if a prompt result was stored server side for the user. However, this caused the prompt to be shown only on a single device at a time. After the change the JavaScript was always attached. The new logic would only re-show a prompt after [time-since-unix-epoch] which would be very long. However, due to a limitation ofsetTimeout
this wrapped around to 0 which caused the prompt to be shown again immediately.A caveat to the implementation in 🐛 Re-installing the app invalidates the subscription but not the pop-up Fixed is that platforms require support for localStorage now to be able to support push notifications. With the information we currently have, all push notification enabled platforms also support localStorage.
-
robertragas →
committed e9e74f71 on 2.1.x
Issue #3447595 : When the user has seen the pop-up and the prompt has...
-
robertragas →
committed e9e74f71 on 2.1.x
- Status changed to Fixed
8 months ago 12:40pm 16 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.