- Issue created by @RedwanJamous
- Merge request !58Issue #3447559 by Redwan Jamous: Fix admin theme library not attached for entity types other than node → (Merged) created by Unnamed author
- Issue was unassigned.
- Status changed to Needs review
6 months ago 9:31am 16 May 2024 - 🇯🇴Jordan Rajab Natshah Jordan
varbase_layout_builder/claro10
is in the VLB 10.0.x branch for Varbase 9
Do we need this fix in VLB 10.1.x branch for Varbase 10 too? @Rajab Natshah, yes we do as this is not specifically related to
varbase_layout_builder/claro10
and the same issue will happen with any admin theme.- 🇯🇴Jordan Rajab Natshah Jordan
Got that, Thanks for clearing that out.
Let us do 2 branches and 2 MRs
one for10.0.x
and one for10.1.x
- Merge request !61Issue #3447559 by Redwan Jamous: Fix admin theme library not attached for entity types other than node → (Open) created by Unnamed author
Thank you, Rajab!
I cherry-picked the commit into a new branch and opened a new PR for10.0.x
, leaving the old one for10.1.x.
- Assigned to Rajab Natshah
- 🇯🇴Jordan Rajab Natshah Jordan
Thank you, Redwan, for following up and the MRs!
Had a testing round for latest Varbase 9.1.x and Varbase 10.0.x released changes and fixes.
I'm not able to reproduce the issueEnable layout builder for any entity type other than node
Tested with Taxonomies, Block types, and Mini Layouts custom entity type .
- Which version of VLB you are using?
- Is issue with a custom coded entity types?
- Do you have a custom styling for it in the project?
- 📌 Update mixed styling with Layout Builder with latest Gin and Claro changes Fixed
- 🐛 Fix Failed theme switch to Admin theme in insert media in 3rd AJAX level in CKEditor 5 Needs work
- 🐛 Fix missing vertical tabs styling in Rich Text block for Media Type links in Media Library modal call with CKEditor 5 Fixed
- 🐛 [Drupal 10.2 regression] Media Library "widget" View media type tabs have lost styling RTBC
- 🐛 Fix not rendered selection checkbox for Media Library grid widget after searching Fixed
Even tho, it feels logical to switch to your logic on
preg_match('/^layout_builder\.overrides\.[a-z0-9_]+\.view$/', $url_object->getRouteName())
-
Rajab Natshah →
committed 6c569b37 on 10.1.x authored by
Redwan Jamous →
Issue #3447559 by Redwan Jamous: Fix admin theme library not attached...
-
Rajab Natshah →
committed 6c569b37 on 10.1.x authored by
Redwan Jamous →
-
Rajab Natshah →
committed 3d074a36 on 10.0.x authored by
Redwan Jamous →
Issue #3447559 by Redwan Jamous: Fix admin theme library not attached...
-
Rajab Natshah →
committed 3d074a36 on 10.0.x authored by
Redwan Jamous →
- Issue was unassigned.
- Status changed to Fixed
6 months ago 8:47am 6 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.