- Issue created by @tim-diels
- Assigned to atul_ghate
- Issue was unassigned.
- Status changed to Needs review
7 months ago 7:02am 17 May 2024 - Status changed to Needs work
7 months ago 3:16pm 18 May 2024 - ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
Thank you for the work. Looks good.
I am not sure if the existing zone id from config is deleted automaticallyโฆ is this something you tested? Otherwise we need to clean up existing config to delete the key and value. Could you please test and report back?
- ๐ฎ๐ณIndia atul_ghate
Hello Tim-diels,
I have tested with an existing zone ID, and it is not deleting the existing zone ID but placing it at the bottom of the cloudflare_stream.settings.yml file. When we remove the zone ID field and schema.
- ๐ง๐ชBelgium tim-diels Belgium ๐ง๐ช
@atul_ghate thanks for the verification.
Then we need to delete this from existing config with an update hook. This should be added to the MR.
-
tim-diels โ
committed 2a450d06 on 3.0.x authored by
atul_ghate โ
Issue #3446508 by tim-diels, atul_ghate: Remove zone ID from the...
-
tim-diels โ
committed 2a450d06 on 3.0.x authored by
atul_ghate โ
- Status changed to Fixed
7 months ago 2:31pm 22 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.