- Issue created by @mmarler
- First commit to issue fork.
- 🇮🇳India sarwan_verma
Hi @mmarler,
I have fixed this issue "Drupal 11 compatibility" and also attached patch,
please review and verify. - Status changed to Needs review
6 months ago 12:49pm 17 May 2024 - Assigned to mark_fullmer
- Status changed to Needs work
6 months ago 7:24pm 22 May 2024 - 🇺🇸United States mark_fullmer Tucson
Thanks for the contribution, sarwan_verma. This module uses a library based in jQuery, and since Drupal 11 is updating to jQuery 4, we'll need to ensure that the library works with jQuery 4. Here is a complete audit of the Drupal 11 compatibility, per the instructions in the issue description:
Drupal 11 compatibility audit: responsive_tables_filterAuditor checklist
- Deprecated Drupal code is remediated
- Deprecated PHP code is remediated
- Custom code is compatible with jQuery 4
- Custom code core_version_requirement indicates Drupal 11 compatibility
References
- Drupal 10 deprecations: https://dev.acquia.com/drupal10/deprecation_status/errors
- jQuery 4 deprecations: https://blog.jquery.com/2024/02/06/jquery-4-0-0-beta/
Composer
- This module does not have a composer.json file
PHPStan Audit of Drupal deprecations
[OK] No errors
Drupal-Rector Audit of Drupal deprecations
[OK] Rector is done!
Audit of deprecated PHP <8.3 calls
If no errors are listed below, php-compatibility did not find any.
...... 6 / 6 (100%) Time: 45ms; Memory: 10MB
jQuery 4 compatibility: List of all custom JavaScript files
Any files listed below should be reviewed for jQuery 4 compatibility
web/modules/contrib/responsive_tables_filter/js/customizations.js web/modules/contrib/responsive_tables_filter/js/tablesaw-init.js web/modules/contrib/responsive_tables_filter/js/tablesaw.min.js web/modules/contrib/responsive_tables_filter/js/Drupal/ajaxComplete.js
Diff for updating core_version_requirement
diff --git a/responsive_tables_filter.info.yml b/responsive_tables_filter.info.yml index c4fee46..33a27d3 100644 --- a/responsive_tables_filter.info.yml +++ b/responsive_tables_filter.info.yml @@ -1,6 +1,6 @@ name: Responsive Tables Filter type: module description: Make tables in text format fields responsive -core_version_requirement: '^9 || ^10' +core_version_requirement: ^10 || ^11 package: Other configure: responsive_tables_filter.settings
- Status changed to Needs review
6 months ago 10:04pm 22 May 2024 -
mark_fullmer →
committed e32377a8 on 2.x
Issue #3446379: Drupal 11 compatibility
-
mark_fullmer →
committed e32377a8 on 2.x
- Status changed to Fixed
6 months ago 7:17pm 24 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.