Drupal 11 compatibility

Created on 9 May 2024, 6 months ago
Updated 7 June 2024, 5 months ago

Problem/motivation

Drupal 11 will be released in 2024.

Steps to make Drupal 11 compatible

  1. Check for Drupal 11 code compatibility
  2. Check for PHP 8.3 compatibility
  3. Check for jQuery 4 compatibility
  4. Update core version requirements to include Drupal 11
  5. Drop Drupal 8 and 9 support
  6. Unit tests are updated to work with Drupal 11 (PHPUnit 10)
  7. Automated tests pass D11 compatibility
  8. Change version numbering to use semantic versioning https://semver.org/
This module uses Gitlab CI for automated testing of proposed code changes. To contribute code changes, create a merge request. Patch files will not trigger automated testing and are not sufficient for review.
📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States mmarler

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @mmarler
  • First commit to issue fork.
  • 🇮🇳India sarwan_verma

    Hi @mmarler,
    I have fixed this issue "Drupal 11 compatibility" and also attached patch,
    please review and verify.

  • Status changed to Needs review 6 months ago
  • 🇺🇸United States mark_fullmer Tucson
  • Assigned to mark_fullmer
  • Status changed to Needs work 6 months ago
  • 🇺🇸United States mark_fullmer Tucson

    Thanks for the contribution, sarwan_verma. This module uses a library based in jQuery, and since Drupal 11 is updating to jQuery 4, we'll need to ensure that the library works with jQuery 4. Here is a complete audit of the Drupal 11 compatibility, per the instructions in the issue description:

    Drupal 11 compatibility audit: responsive_tables_filter

    Auditor checklist

    • Deprecated Drupal code is remediated
    • Deprecated PHP code is remediated
    • Custom code is compatible with jQuery 4
    • Custom code core_version_requirement indicates Drupal 11 compatibility

    References

    Composer

    • This module does not have a composer.json file

    PHPStan Audit of Drupal deprecations

     [OK] No errors                                                                                                         
    

    Drupal-Rector Audit of Drupal deprecations

    
     [OK] Rector is done!                                                                                                   
    

    Audit of deprecated PHP <8.3 calls

    If no errors are listed below, php-compatibility did not find any.

    ...... 6 / 6 (100%)
    
    
    Time: 45ms; Memory: 10MB
    

    jQuery 4 compatibility: List of all custom JavaScript files

    Any files listed below should be reviewed for jQuery 4 compatibility

    web/modules/contrib/responsive_tables_filter/js/customizations.js
    web/modules/contrib/responsive_tables_filter/js/tablesaw-init.js
    web/modules/contrib/responsive_tables_filter/js/tablesaw.min.js
    web/modules/contrib/responsive_tables_filter/js/Drupal/ajaxComplete.js
    

    Diff for updating core_version_requirement

    diff --git a/responsive_tables_filter.info.yml b/responsive_tables_filter.info.yml
    index c4fee46..33a27d3 100644
    --- a/responsive_tables_filter.info.yml
    +++ b/responsive_tables_filter.info.yml
    @@ -1,6 +1,6 @@
     name: Responsive Tables Filter
     type: module
     description: Make tables in text format fields responsive
    -core_version_requirement: '^9 || ^10'
    +core_version_requirement: ^10 || ^11
     package: Other
     configure: responsive_tables_filter.settings
    
  • Merge request !15Resolve #3446379 "Drupal 11 compatibility" → (Merged) created by mark_fullmer
  • Status changed to Needs review 6 months ago
  • 🇺🇸United States mark_fullmer Tucson
  • Pipeline finished with Skipped
    6 months ago
    #181550
  • Status changed to Fixed 6 months ago
  • 🇺🇸United States mark_fullmer Tucson
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024