Fix coding standards

Hi

I reviewed MR!12, applied against Ridiculously Responsive Social Sharing Buttons 8.x-2.x-dev and there are still phpcs issues shown below:

jetherparadero@PrometSources-MacBook-Pro-3 contrib % phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig rrssb

FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/rrssb.module
-------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------
 20 | WARNING | Global constants should not be used, move it to a class or interface
-------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/src/Form/RRSSBSettingsForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------------------------
  79 | WARNING | Variable $require_follow inside unset call is undefined.
 186 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
 189 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------


FILE: /Users/jetherparadero/d_o/drupal-issues/web/modules/contrib/rrssb/src/Plugin/Block/RRSSBBlock.php
-------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------
 27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------

Time: 310ms; Memory: 12MB

Kindly check and advise, please.
Thank you.

@paraderojether Please note that this issue is to fix the coding standards issues identified by GitLab CI, which you can see are fixed in the pipeline here: https://git.drupalcode.org/issue/rrssb-3446292/-/jobs/1557122

The GitLab CI tests will report DI issues like

 27 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead

as phpstan issues, not coding standards issues. I guess this is to ensure that issues don't get fixed twice (no duplication of work).

You can see that the DI issues are fixed in the phpstan issue: https://www.drupal.org/project/rrssb/issues/3446295 📌 Fix phpstan issues Needs review

Thanks

Automatically closed - issue fixed for 2 weeks with no activity.