Enforce null coalescing operator ?? instead of a ternary operator through phpcs

Added the rule, there are some violations on core since the original big push to change this. Fixed those autmaticly.

All reported places are fixed, hope tests are green as changes makes sense

There are two different patterns here that we are fixing -- comparing to NULL and using isset() -- but the number of changes is small enough that it's sensible to fix both in a single issue.

Enabling new rules is a good alpha-ish-beta-ish target, so I've committed the issue to 11.x and cherry-picked it to 11.0.x. It did not cherry-pick cleanly to 10.4.x, so we need an updated version for the D10 backport.

Thanks!

Cool, I'll make a new branch for 10

Changes look good, you also changes the 2 liner, great :)

Wish i was at a table in portland :(

Think something went wrong, spellcheck failed. Did rebase go well?

Made a fresh Mr against 10.4.x seems that one is fine.

bbrala → changed the visibility of the branch 3446107-use-null-coalescing-10.4 to hidden.

Committed to 10.4.x and cherry-picked to 10.3.x. (Hopefully I did not break 10.3...)

Thanks!

andypost → closed merge request !7978

xjm → closed merge request !7979

xjm → closed merge request !7977

(Oh, I forgot to mention that previously we would have included this in the release notes, but as we've added more and more rules, we've moved away from enumerating them all the time since the tools tell you which they are.)

thank for elaboration

Automatically closed - issue fixed for 2 weeks with no activity.